From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steffen Trumtrar Subject: Re: [PATCH 1/2] Documentation: devicetree: add epson rx6110 binding Date: Wed, 25 Nov 2015 10:00:26 +0100 Message-ID: <20151125090026.GD14709@pengutronix.de> References: <1448361533-10728-1-git-send-email-s.trumtrar@pengutronix.de> <20151124235337.GA18195@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151124235337.GA18195@rob-hp-laptop> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Alessandro Zummo , Alexandre Belloni , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Nov 24, 2015 at 05:54:00PM -0600, Rob Herring wrote: > On Tue, Nov 24, 2015 at 11:38:52AM +0100, Steffen Trumtrar wrote: > > Add the binding documentation for the Epson RX6110 RTC. > > > > Signed-off-by: Steffen Trumtrar > > --- > > I'm not sure what the current policy for such simple SPI bindings is. > > Are they necessary? > > Yes. We do have trivial-devices.txt for i2c. We could do one for spi. > Although, you need the mode configuration for each device, so spi is not > so trivial. > Very good. I thought so. > > > > .../devicetree/bindings/rtc/epson,rtc-rx6110.txt | 25 ++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt > > > > diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt b/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt > > new file mode 100644 > > index 000000000000..7ce7ae761657 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt > > @@ -0,0 +1,25 @@ > > +Epson RX6110 Real Time Clock > > +============================ > > + > > +The Epson RX6110 can be used with SPI or I2C busses. The kind of > > +bus depends on the SPISEL pin and can not be configured via software. > > Can you document I2C mode. It should just be the compatible and reg > properties. > Okay, will do. Thanks, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html