Re: [PATCH 1/2] Documentation: devicetree: add epson rx6110 binding

[Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On Tue, Nov 24, 2015 at 12:12:41PM +0100, Philipp Zabel wrote:
> Am Dienstag, den 24.11.2015, 11:38 +0100 schrieb Steffen Trumtrar:
> > Add the binding documentation for the Epson RX6110 RTC.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > ---
> > I'm not sure what the current policy for such simple SPI bindings is.
> > Are they necessary?
> 
> Like for i2c there is trivial-devices.txt? Although in this case it's
> not just a compatible. Here you have a certain spi configuration that is
> necessary for the rtc to work.
> 
> >  .../devicetree/bindings/rtc/epson,rtc-rx6110.txt   | 25 ++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt b/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt
> > new file mode 100644
> > index 000000000000..7ce7ae761657
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/epson,rtc-rx6110.txt
> > @@ -0,0 +1,25 @@
> > +Epson RX6110 Real Time Clock
> > +============================
> > +
> > +The Epson RX6110 can be used with SPI or I2C busses. The kind of
> > +bus depends on the SPISEL pin and can not be configured via software.
> > +
> > +SPI mode
> > +--------
> > +
> > +Required properties:
> > +- compatible: should be: "epson,rtc-rx6110"
> 
> Should this just be "epson,rx6110" ?
> 
> > +- reg: chip select number
> > +- spi-cs-high: RX6110 needs chipselect high
> > +- spi-cpha: RX6110 works with SPI shifted clock phase
> > +- spi-cpol: RX6110 works with SPI inverse clock polarity
> > +
> > +Example:
> > +
> > +	rtc: rtc@3 {
> > +		compatible = "epson,rtc-rx6110"
> > +		reg = <3>
> > +		spi-cs-high;
> > +		spi-cpba;
> 
> s/b/h/

I thought I copy-pasted this; seems I didn't =-o

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html