From: Wolfram Sang <wsa@the-dreams.de>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Jaedon Shin <jaedon.shin@gmail.com>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH 3/9] i2c: brcmstb: add missing parenthesis
Date: Mon, 30 Nov 2015 16:36:04 +0100 [thread overview]
Message-ID: <20151130153604.GN1513@katana> (raw)
In-Reply-To: <5628425C.5080104@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
On Wed, Oct 21, 2015 at 06:56:44PM -0700, Florian Fainelli wrote:
> Le 20/10/2015 19:36, Jaedon Shin a écrit :
> > Add the necessary parenthesis for NOACK condition.
> >
> > Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
I wouldn't call them necessary?
>
> > ---
> > drivers/i2c/busses/i2c-brcmstb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
> > index 6b8bbf99880d..2d7d155029dc 100644
> > --- a/drivers/i2c/busses/i2c-brcmstb.c
> > +++ b/drivers/i2c/busses/i2c-brcmstb.c
> > @@ -305,7 +305,7 @@ static int brcmstb_send_i2c_cmd(struct brcmstb_i2c_dev *dev,
> > }
> >
> > if ((CMD_RD || CMD_WR) &&
> > - bsc_readl(dev, iic_enable) & BSC_IIC_EN_NOACK_MASK) {
> > + (bsc_readl(dev, iic_enable) & BSC_IIC_EN_NOACK_MASK)) {
> > rc = -EREMOTEIO;
> > dev_dbg(dev->device, "controller received NOACK intr for %s\n",
> > cmd_string[cmd]);
> >
>
>
> --
> Florian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-11-30 15:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 2:36 [PATCH 0/9] i2c: brcmstb: add support for BMIPS_GENERIC Jaedon Shin
2015-10-21 2:36 ` [PATCH 1/9] i2c: brcmstb: make the driver buildable on BMIPS_GENERIC Jaedon Shin
2015-10-22 1:56 ` Florian Fainelli
2015-10-21 2:36 ` [PATCH 3/9] i2c: brcmstb: add missing parenthesis Jaedon Shin
2015-10-22 1:56 ` Florian Fainelli
2015-11-30 15:36 ` Wolfram Sang [this message]
2015-10-21 2:36 ` [PATCH 4/9] i2c: brcmstb: enable ACK condition Jaedon Shin
2015-11-30 15:37 ` Wolfram Sang
[not found] ` <1445395021-4204-1-git-send-email-jaedon.shin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-21 2:36 ` [PATCH 2/9] i2c: brcmstb: fix typo in i2c-brcmstb Jaedon Shin
2015-10-22 1:56 ` Florian Fainelli
2015-10-21 2:36 ` [PATCH 5/9] i2c: brcmstb: fix start and stop conditions Jaedon Shin
2015-11-30 15:41 ` Wolfram Sang
2015-10-21 2:36 ` [PATCH 6/9] MIPS: BMIPS: brcmstb: add I2C node for bcm7346 Jaedon Shin
[not found] ` <1445395021-4204-7-git-send-email-jaedon.shin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-22 1:57 ` Florian Fainelli
2015-10-21 2:36 ` [PATCH 7/9] MIPS: BMIPS: brcmstb: add I2C node for bcm7358 Jaedon Shin
2015-10-22 1:57 ` Florian Fainelli
2015-10-21 2:37 ` [PATCH 8/9] MIPS: BMIPS: brcmstb: add I2C node for bcm7360 Jaedon Shin
2015-10-22 1:57 ` Florian Fainelli
2015-10-21 2:37 ` [PATCH 9/9] MIPS: BMIPS: brcmstb: add I2C node for bcm7362 Jaedon Shin
2015-10-22 1:57 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130153604.GN1513@katana \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).