Re: [PATCH 1/3] dt-bindings: add Marvell core PLL and clock divider PMU documentation

Rob Herring
2015-11-30T21:03:45Z

On Fri, Nov 27, 2015 at 08:39:32PM +0000, Russell King - ARM Linux wrote:
> On Fri, Nov 27, 2015 at 02:21:14PM -0600, Rob Herring wrote:
> > On Thu, Nov 26, 2015 at 10:23:21PM +0000, Russell King wrote:
> > > Add documentation for the Marvell clock divider driver, which is used
> > > to source clocks for the AXI bus, video decoder, GPU and LCD blocks.
> > >
> > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > > ---
> > > .../bindings/clock/dove-divider-clock.txt | 28 ++++++++++++++++++++++
> > > 1 file changed, 28 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/clock/dove-divider-clock.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/clock/dove-divider-clock.txt b/Documentation/devicetree/bindings/clock/dove-divider-clock.txt
> > > new file mode 100644
> > > index 000000000000..0c602de279e5
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/clock/dove-divider-clock.txt
> > > @@ -0,0 +1,28 @@
> > > +PLl divider based Dove clocks
> > > +
> > > +Marvell Dove has a 2GHz PLL, which feeds into a set of dividers to provide
> > > +high speed clocks for a number of peripherals. These dividers are part of
> > > +the PMU, and thus this node should be a child of the PMU node.
> >
> > It seems a bit strange to just be documenting these clocks. What about
> > the rest of the SOC clocks?
>
> This is all that this pair of registers provide.
>
> The SoC has other clocks handled by other DT nodes - for Dove, we now
> have:
>
> gate_clk: clock-gating-ctrl@0038 {
> compatible = "marvell,dove-gating-clock";
> reg = <0x0038 0x4>;
> clocks = <&core_clk 0>;
> #clock-cells = <1>;
> };
> divider_clk: core-clock@0064 {
> compatible = "marvell,dove-divider-clock";
> reg = <0x0064 0x8>;
> #clock-cells = <1>;
> };
> core_clk: core-clocks@0214 {
> compatible = "marvell,dove-core-clock";
> reg = <0x0214 0x4>;
> #clock-cells = <1>;
> };
>
> and all three of these are part of the PMU register block. I'm not sure
> why the mvebu maintainers decided to minutely describe the PMU like this,
> but unfortunately that's the structure we have.

Okay,

Acked-by: Rob Herring <robh@kernel.org>

> IMHO, it would've been cleaner to have these components registered
> separately from a central PMU driver (as I'm doing with the power
> domains, resets and IRQs that are part of the PMU), but my view is
> limited to Dove and not the other mvebu clocks, so there may be a good
> reason for it.

Yes, we debated which way to go early on and decided generally to go
this direction, but it seems Dove was before that. We could try to
migrate Dove, but it is probably not worth the pain at this point.

Rob