devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Heiko Schocher <hs-ynQEQJNshbs@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Robert Nelson"
	<robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Dave Gerlach" <d-gerlach-l0cyMroinI0@public.gmane.org>,
	Georg.Soffel-k21M0aUVSxZWk0Htik3J/w@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2] arm, am335x: add support for the bosch shc board
Date: Mon, 30 Nov 2015 13:41:30 -0800	[thread overview]
Message-ID: <20151130214130.GA23396@atomide.com> (raw)
In-Reply-To: <1447748655-2088-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>

* Heiko Schocher <hs-ynQEQJNshbs@public.gmane.org> [151117 00:25]:
> --- /dev/null
> +++ b/arch/arm/boot/dts/am335x-shc.dts
> +&tps {
> +	compatible = "ti,tps65217";
> +	ti,pmic-shutdown-controller;
> +
> +	regulators {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		dcdc1_reg: regulator@0 {
> +			reg = <0>;
> +			regulator-name = "vdds_dpr";
> +			regulator-compatible = "dcdc1";
> +			regulator-min-microvolt = <1300000>;
> +			regulator-max-microvolt = <1450000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +
> +		dcdc2_reg: regulator@1 {
> +			reg = <1>;
> +			/*
> +			 * VDD_MPU voltage limits 0.95V - 1.26V with
> +			 * +/-4% tolerance
> +			 */
> +			regulator-compatible = "dcdc2";
> +			regulator-name = "vdd_mpu";
> +			regulator-min-microvolt = <925000>;
> +			regulator-max-microvolt = <1375000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +			regulator-ramp-delay = <70000>;
> +		};
> +
> +		dcdc3_reg: regulator@2 {
> +			reg = <2>;
> +			/*
> +			 * VDD_CORE voltage limits 0.95V - 1.1V with
> +			 * +/-4% tolerance
> +			 */
> +			regulator-name = "vdd_core";
> +			regulator-compatible = "dcdc3";
> +			regulator-min-microvolt = <925000>;
> +			regulator-max-microvolt = <1125000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +
> +		ldo1_reg: regulator@3 {
> +			reg = <3>;
> +			regulator-name = "vio,vrtc,vdds";
> +			regulator-compatible = "ldo1";
> +			regulator-min-microvolt = <1000000>;
> +			regulator-max-microvolt = <1800000>;
> +			regulator-always-on;
> +		};
> +
> +		ldo2_reg: regulator@4 {
> +			reg = <4>;
> +			regulator-name = "vdd_3v3aux";
> +			regulator-compatible = "ldo2";
> +			regulator-min-microvolt = <900000>;
> +			regulator-max-microvolt = <3300000>;
> +			regulator-always-on;
> +		};
> +
> +		ldo3_reg: regulator@5 {
> +			reg = <5>;
> +			regulator-name = "vdd_1v8";
> +			regulator-compatible = "ldo3";
> +			regulator-min-microvolt = <900000>;
> +			regulator-max-microvolt = <1800000>;
> +			regulator-always-on;
> +		};
> +
> +		ldo4_reg: regulator@6 {
> +			reg = <6>;
> +			regulator-name = "vdd_3v3a";
> +			regulator-compatible = "ldo4";
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <3300000>;
> +			regulator-always-on;
> +		};
> +	};
> +};

Applying this into omap-for-v4.5/dt.. But I'm getting concerned about this
"regulator-always-on" stuff and having multiple copies of the same thing.

I think we should have a common am33xx-tps65217.dtsi file that has the
regulators defined at one place and other then include it. And they are
controllable AFAIK..

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-30 21:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17  8:24 [PATCH v2] arm, am335x: add support for the bosch shc board Heiko Schocher
     [not found] ` <1447748655-2088-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2015-11-17 21:29   ` Dave Gerlach
2015-11-18  8:24     ` Heiko Schocher
2015-11-30  6:51       ` Heiko Schocher
2015-11-30 16:34         ` Tony Lindgren
2015-11-30 21:41   ` Tony Lindgren [this message]
2015-12-01  5:19     ` Heiko Schocher
2015-12-01  5:53       ` Tony Lindgren
2015-12-01  6:09         ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130214130.GA23396@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=Georg.Soffel-k21M0aUVSxZWk0Htik3J/w@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=d-gerlach-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hs-ynQEQJNshbs@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).