[PATCH] ravb: add R8A7791 support

[PATCH] ravb: add R8A7791 support

[Sergei Shtylyov]

Add support  for yet another ARM member of the R-Car family, R-Car M2, also
known as R8A7791.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against DaveM's 'net-next.git' repo but I wouldn't mind if it's
applied to 'net.git' instead. :-)

 Documentation/devicetree/bindings/net/renesas,ravb.txt |    1 +
 drivers/net/ethernet/renesas/ravb_main.c               |    1 +
 2 files changed, 2 insertions(+)

Index: net-next/Documentation/devicetree/bindings/net/renesas,ravb.txt
===================================================================
--- net-next.orig/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ net-next/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -5,6 +5,7 @@ interface contains.
 
 Required properties:
 - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC.
+	      "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
 	      "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
 	      "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
 - reg: offset and length of (1) the register block and (2) the stream buffer.
Index: net-next/drivers/net/ethernet/renesas/ravb_main.c
===================================================================
--- net-next.orig/drivers/net/ethernet/renesas/ravb_main.c
+++ net-next/drivers/net/ethernet/renesas/ravb_main.c
@@ -1655,6 +1655,7 @@ static int ravb_mdio_release(struct ravb
 
 static const struct of_device_id ravb_match_table[] = {
 	{ .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
+	{ .compatible = "renesas,etheravb-r8a7791", .data = (void *)RCAR_GEN2 },
 	{ .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
 	{ .compatible = "renesas,etheravb-r8a7795", .data = (void *)RCAR_GEN3 },
 	{ }

Re: [PATCH] ravb: add R8A7791 support

[Geert Uytterhoeven]

Hi Sergei,

On Fri, Nov 27, 2015 at 11:06 PM, Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> Add support  for yet another ARM member of the R-Car family, R-Car M2, also

R-Car M2-W?

> known as R8A7791.

There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ravb: add R8A7791 support

[Sergei Shtylyov]

Hello.

On 11/29/2015 10:26 PM, Geert Uytterhoeven wrote:

>> Add support  for yet another ARM member of the R-Car family, R-Car M2, also

> R-Car M2-W?

    Right, forgot about the postfixes.

>> known as R8A7791.
>
> There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)

    Will fix.

> Gr{oetje,eeting}s,
>
>                          Geert

MBR, Sergei

Re: [PATCH] ravb: add R8A7791 support

[Simon Horman]

On Mon, Nov 30, 2015 at 12:14:21AM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/29/2015 10:26 PM, Geert Uytterhoeven wrote:
> 
> >>Add support  for yet another ARM member of the R-Car family, R-Car M2, also
> 
> >R-Car M2-W?
> 
>    Right, forgot about the postfixes.
> 
> >>known as R8A7791.
> >
> >There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)
> 
>    Will fix.

I would prefer if we added generic gen2 and gen3 compat strings to the driver
and only documented new soc-specific compat strings.

Actually by chance I was planning to up patches to do that and add compat
strings for the missing Gen2 boards. But I won't complain if you beat me to
it.

Re: [PATCH] ravb: add R8A7791 support

[Geert Uytterhoeven]

Hi Simon,

On Mon, Nov 30, 2015 at 1:42 AM, Simon Horman <horms@verge.net.au> wrote:
> On Mon, Nov 30, 2015 at 12:14:21AM +0300, Sergei Shtylyov wrote:
>> On 11/29/2015 10:26 PM, Geert Uytterhoeven wrote:
>> >>Add support  for yet another ARM member of the R-Car family, R-Car M2, also
>> >R-Car M2-W?
>>
>>    Right, forgot about the postfixes.
>>
>> >>known as R8A7791.
>> >
>> >There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)
>>
>>    Will fix.
>
> I would prefer if we added generic gen2 and gen3 compat strings to the driver
> and only documented new soc-specific compat strings.
>
> Actually by chance I was planning to up patches to do that and add compat
> strings for the missing Gen2 boards. But I won't complain if you beat me to
> it.

You're aware we have to keep the existing SoC-specific ones in the driver,
for backwards compatibility?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ravb: add R8A7791 support

[Simon Horman]

On Mon, Nov 30, 2015 at 09:08:57AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Nov 30, 2015 at 1:42 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Mon, Nov 30, 2015 at 12:14:21AM +0300, Sergei Shtylyov wrote:
> >> On 11/29/2015 10:26 PM, Geert Uytterhoeven wrote:
> >> >>Add support  for yet another ARM member of the R-Car family, R-Car M2, also
> >> >R-Car M2-W?
> >>
> >>    Right, forgot about the postfixes.
> >>
> >> >>known as R8A7791.
> >> >
> >> >There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)
> >>
> >>    Will fix.
> >
> > I would prefer if we added generic gen2 and gen3 compat strings to the driver
> > and only documented new soc-specific compat strings.
> >
> > Actually by chance I was planning to up patches to do that and add compat
> > strings for the missing Gen2 boards. But I won't complain if you beat me to
> > it.
> 
> You're aware we have to keep the existing SoC-specific ones in the driver,
> for backwards compatibility?

Yes, I am aware of that.

Re: [PATCH] ravb: add R8A7791 support

[Sergei Shtylyov]

Hello.

On 11/30/2015 03:42 AM, Simon Horman wrote:

>>>> Add support  for yet another ARM member of the R-Car family, R-Car M2, also
>>
>>> R-Car M2-W?
>>
>>     Right, forgot about the postfixes.
>>
>>>> known as R8A7791.
>>>
>>> There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)
>>
>>     Will fix.
>
> I would prefer if we added generic gen2 and gen3 compat strings to the driver
> and only documented new soc-specific compat strings.

    That's a new policy it seems. Previously you preferred the SoC-specific 
strings to be used, didn;t you?

> Actually by chance I was planning to up patches to do that and add compat
> strings for the missing Gen2 boards. But I won't complain if you beat me to
> it.

    No, I'm pretty busy as is. :-)

MBR, Sergei

Re: [PATCH] ravb: add R8A7791 support

[Simon Horman]

On Mon, Nov 30, 2015 at 10:08:22PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/30/2015 03:42 AM, Simon Horman wrote:
> 
> >>>>Add support  for yet another ARM member of the R-Car family, R-Car M2, also
> >>
> >>>R-Car M2-W?
> >>
> >>    Right, forgot about the postfixes.
> >>
> >>>>known as R8A7791.
> >>>
> >>>There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)
> >>
> >>    Will fix.
> >
> >I would prefer if we added generic gen2 and gen3 compat strings to the driver
> >and only documented new soc-specific compat strings.
> 
>    That's a new policy it seems. Previously you preferred the SoC-specific
> strings to be used, didn;t you?

Yes, that is correct on all counts.

To clarify new policy for Renesas IP is:
	soc-specific compat + generic compat as fallback

> >Actually by chance I was planning to up patches to do that and add compat
> >strings for the missing Gen2 boards. But I won't complain if you beat me to
> >it.
> 
>    No, I'm pretty busy as is. :-)

Ok, I'll handle this.