From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Date: Tue, 1 Dec 2015 09:59:40 +0100 Message-ID: <20151201085940.GC29263@lukather> References: <1445557577-27383-1-git-send-email-vishnupatekar0510@gmail.com> <1445557577-27383-3-git-send-email-vishnupatekar0510@gmail.com> <20151025202012.GT10947@lukather> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nmemrqcdn5VTmUEE" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Vishnu Patekar Cc: "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "pawel.moll-5wv7dgnIgG8@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , Kumar Gala , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , Emilio Lopez , Linus Walleij , Jens Kuske , Hans de Goede , Chen-Yu Tsai , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --nmemrqcdn5VTmUEE Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi! On Mon, Nov 30, 2015 at 02:09:14AM +0800, Vishnu Patekar wrote: > >> + reg = <0x01c20800 0x400>; > >> + clocks = <&osc24M>; > >> + gpio-controller; > >> + interrupt-controller; > >> + #interrupt-cells = <3>; > >> + #gpio-cells = <3>; > >> + > >> + i2c0_pins_a: i2c0@0 { > >> + allwinner,pins = "PH0", "PH1"; > >> + allwinner,function = "i2c0"; > >> + allwinner,drive = ; > >> + allwinner,pull = ; > >> + }; > >> + > >> + i2c1_pins_a: i2c1@0 { > >> + allwinner,pins = "PH2", "PH3"; > >> + allwinner,function = "i2c1"; > >> + allwinner,drive = ; > >> + allwinner,pull = ; > >> + }; > >> + > >> + i2c2_pins_a: i2c2@0 { > >> + allwinner,pins = "PH4", "PH5"; > >> + allwinner,function = "i2c2"; > >> + allwinner,drive = ; > >> + allwinner,pull = ; > >> + }; > >> + > >> + mmc0_pins_a: mmc0@0 { > >> + allwinner,pins = "PF0", "PF1", "PF2", > >> + "PF3", "PF4", "PF5"; > >> + allwinner,function = "mmc0"; > >> + allwinner,drive = ; > >> + allwinner,pull = ; > >> + }; > >> + > >> + mmc1_pins_a: mmc1@0 { > >> + allwinner,pins = "PG0", "PG1", "PG2", > >> + "PG3", "PG4", "PG5"; > >> + allwinner,function = "mmc1"; > >> + allwinner,drive = ; > >> + allwinner,pull = ; > >> + }; > >> + > >> + mmc2_8bit_pins: mmc2_8bit { > >> + allwinner,pins = "PC5", "PC6", "PC8", > >> + "PC9", "PC10", "PC11", > >> + "PC12", "PC13", "PC14", > >> + "PC15"; > >> + allwinner,function = "mmc2"; > >> + allwinner,drive = ; > >> + allwinner,pull = ; > >> + }; > >> + > >> + uart0_pins_a: uart0@0 { > >> + allwinner,pins = "PF2", "PF4"; > >> + allwinner,function = "uart0"; > >> + allwinner,drive = ; > >> + allwinner,pull = ; > >> + }; > >> + > >> + uart0_pins_b: uart0@1 { > >> + allwinner,pins = "PB9", "PB10"; > >> + allwinner,function = "uart0"; > >> + allwinner,drive = ; > >> + allwinner,pull = ; > >> + }; > > > > Are you going to use all these options? > > Not, only uart0_pins_a and uart0_pins_b and mmc0_pins_a will be used for now. > As, these are not enabled, I don't see any harm in keeping those here. It bloats the DT for no particular reason. > Let me know in case you want to remove, I'll do it. Yes, please. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --nmemrqcdn5VTmUEE--