* [PATCH 0/2 net-next] ravb: More compat strings @ 2015-12-01 7:43 Simon Horman 2015-12-01 7:43 ` [PATCH 1/2 net-next] ravb: Add fallback compatibility strings Simon Horman 2015-12-01 7:43 ` [PATCH 2/2 net-next] ravb: Add device tree support for r8a779[123] Simon Horman 0 siblings, 2 replies; 7+ messages in thread From: Simon Horman @ 2015-12-01 7:43 UTC (permalink / raw) To: netdev, linux-sh; +Cc: Magnus Damm, Sergei Shtylyov, devicetree Hi, this short series adds generic gen2 and gen3, and soc-specific compat strings for the missing gen2 SoCs. Simon Horman (2): ravb: Add fallback compatibility strings ravb: Add device tree support for r8a779[123] Documentation/devicetree/bindings/net/renesas,ravb.txt | 14 ++++++++++++-- drivers/net/ethernet/renesas/ravb_main.c | 2 ++ 2 files changed, 14 insertions(+), 2 deletions(-) -- 2.1.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2 net-next] ravb: Add fallback compatibility strings 2015-12-01 7:43 [PATCH 0/2 net-next] ravb: More compat strings Simon Horman @ 2015-12-01 7:43 ` Simon Horman 2015-12-01 8:42 ` Geert Uytterhoeven 2015-12-01 10:26 ` Sergei Shtylyov 2015-12-01 7:43 ` [PATCH 2/2 net-next] ravb: Add device tree support for r8a779[123] Simon Horman 1 sibling, 2 replies; 7+ messages in thread From: Simon Horman @ 2015-12-01 7:43 UTC (permalink / raw) To: netdev, linux-sh; +Cc: Magnus Damm, Sergei Shtylyov, devicetree Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Also correct typo. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 11 +++++++++-- drivers/net/ethernet/renesas/ravb_main.c | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt index b486f3f5f6a3..115006325bff 100644 --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt @@ -1,12 +1,19 @@ * Renesas Electronics Ethernet AVB This file provides information on what the device node for the Ethernet AVB -interface contains. +interface. Required properties: - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. + "renesas,etheravb-gen2" for generic R-Car Gen 2 compatible interface. + "renesas,etheravb-gen3" for generic R-Car Gen 3 compatible interface. + + When compatible with the generic version, nodes must list the + SoC-specific version corresponding to the platform first + followed by the generic version. + - reg: offset and length of (1) the register block and (2) the stream buffer. - interrupts: A list of interrupt-specifiers, one for each entry in interrupt-names. @@ -37,7 +44,7 @@ Optional properties: Example: ethernet@e6800000 { - compatible = "renesas,etheravb-r8a7795"; + compatible = "renesas,etheravb-r8a7795", "renesas,etheravb-gen3"; reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; interrupt-parent = <&gic>; interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>, diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 990dc55cdada..d3b4f574d346 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1656,7 +1656,9 @@ static int ravb_mdio_release(struct ravb_private *priv) static const struct of_device_id ravb_match_table[] = { { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 }, { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 }, + { .compatible = "renesas,etheravb-gen2", .data = (void *)RCAR_GEN2 }, { .compatible = "renesas,etheravb-r8a7795", .data = (void *)RCAR_GEN3 }, + { .compatible = "renesas,etheravb-gen3", .data = (void *)RCAR_GEN3 }, { } }; MODULE_DEVICE_TABLE(of, ravb_match_table); -- 2.1.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings 2015-12-01 7:43 ` [PATCH 1/2 net-next] ravb: Add fallback compatibility strings Simon Horman @ 2015-12-01 8:42 ` Geert Uytterhoeven 2015-12-02 0:28 ` Simon Horman 2015-12-01 10:26 ` Sergei Shtylyov 1 sibling, 1 reply; 7+ messages in thread From: Geert Uytterhoeven @ 2015-12-01 8:42 UTC (permalink / raw) To: Simon Horman Cc: netdev@vger.kernel.org, Linux-sh list, Magnus Damm, Sergei Shtylyov, devicetree@vger.kernel.org On Tue, Dec 1, 2015 at 8:43 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Also correct typo. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 11 +++++++++-- > drivers/net/ethernet/renesas/ravb_main.c | 2 ++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > index b486f3f5f6a3..115006325bff 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > @@ -1,12 +1,19 @@ > * Renesas Electronics Ethernet AVB > > This file provides information on what the device node for the Ethernet AVB > -interface contains. > +interface. > > Required properties: > - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. > "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. > "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. > + "renesas,etheravb-gen2" for generic R-Car Gen 2 compatible interface. > + "renesas,etheravb-gen3" for generic R-Car Gen 3 compatible interface. > + (Same comment, different audience) Shouldn't that be "renesas,etheravb-rcar-gen" or "renesas,etheravb-rcar2"? Else you'll be in trouble when Renesas starts focussing on airplanes (R-Plane Gen2), rockets (R-Rocket Gen2), or IoT (R-IoT Gen2). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings 2015-12-01 8:42 ` Geert Uytterhoeven @ 2015-12-02 0:28 ` Simon Horman 0 siblings, 0 replies; 7+ messages in thread From: Simon Horman @ 2015-12-02 0:28 UTC (permalink / raw) To: Geert Uytterhoeven Cc: netdev@vger.kernel.org, Linux-sh list, Magnus Damm, Sergei Shtylyov, devicetree@vger.kernel.org On Tue, Dec 01, 2015 at 09:42:52AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 1, 2015 at 8:43 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > > Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. > > This is in keeping with the fallback scheme being adopted wherever > > appropriate for drivers for Renesas SoCs. > > > > Also correct typo. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > Documentation/devicetree/bindings/net/renesas,ravb.txt | 11 +++++++++-- > > drivers/net/ethernet/renesas/ravb_main.c | 2 ++ > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > index b486f3f5f6a3..115006325bff 100644 > > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > @@ -1,12 +1,19 @@ > > * Renesas Electronics Ethernet AVB > > > > This file provides information on what the device node for the Ethernet AVB > > -interface contains. > > +interface. > > > > Required properties: > > - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. > > "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. > > "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. > > + "renesas,etheravb-gen2" for generic R-Car Gen 2 compatible interface. > > + "renesas,etheravb-gen3" for generic R-Car Gen 3 compatible interface. > > + > > (Same comment, different audience) > > Shouldn't that be "renesas,etheravb-rcar-gen" or "renesas,etheravb-rcar2"? > > Else you'll be in trouble when Renesas starts focussing on airplanes > (R-Plane Gen2), rockets (R-Rocket Gen2), or IoT (R-IoT Gen2). Sure, lets go with: renesas,etheravb-rcar-gen2 and renesas,etheravb-rcar-gen3. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings 2015-12-01 7:43 ` [PATCH 1/2 net-next] ravb: Add fallback compatibility strings Simon Horman 2015-12-01 8:42 ` Geert Uytterhoeven @ 2015-12-01 10:26 ` Sergei Shtylyov 2015-12-02 0:27 ` Simon Horman 1 sibling, 1 reply; 7+ messages in thread From: Sergei Shtylyov @ 2015-12-01 10:26 UTC (permalink / raw) To: Simon Horman, netdev, linux-sh; +Cc: Magnus Damm, devicetree Hello. On 12/1/2015 10:43 AM, Simon Horman wrote: > Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. > This is in keeping with the fallback scheme being adopted wherever > appropriate for drivers for Renesas SoCs. > > Also correct typo. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 11 +++++++++-- > drivers/net/ethernet/renesas/ravb_main.c | 2 ++ > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > index b486f3f5f6a3..115006325bff 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > @@ -1,12 +1,19 @@ > * Renesas Electronics Ethernet AVB > > This file provides information on what the device node for the Ethernet AVB > -interface contains. > +interface. Why? [...] MBR, Sergei ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings 2015-12-01 10:26 ` Sergei Shtylyov @ 2015-12-02 0:27 ` Simon Horman 0 siblings, 0 replies; 7+ messages in thread From: Simon Horman @ 2015-12-02 0:27 UTC (permalink / raw) To: Sergei Shtylyov; +Cc: netdev, linux-sh, Magnus Damm, devicetree On Tue, Dec 01, 2015 at 01:26:08PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/1/2015 10:43 AM, Simon Horman wrote: > > >Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families. > >This is in keeping with the fallback scheme being adopted wherever > >appropriate for drivers for Renesas SoCs. > > > >Also correct typo. > > > >Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >--- > > Documentation/devicetree/bindings/net/renesas,ravb.txt | 11 +++++++++-- > > drivers/net/ethernet/renesas/ravb_main.c | 2 ++ > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > >diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > >index b486f3f5f6a3..115006325bff 100644 > >--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > >+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > >@@ -1,12 +1,19 @@ > > * Renesas Electronics Ethernet AVB > > > > This file provides information on what the device node for the Ethernet AVB > >-interface contains. > >+interface. > > Why? Because I miss read it (multiple times). I'll drop this change. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2 net-next] ravb: Add device tree support for r8a779[123] 2015-12-01 7:43 [PATCH 0/2 net-next] ravb: More compat strings Simon Horman 2015-12-01 7:43 ` [PATCH 1/2 net-next] ravb: Add fallback compatibility strings Simon Horman @ 2015-12-01 7:43 ` Simon Horman 1 sibling, 0 replies; 7+ messages in thread From: Simon Horman @ 2015-12-01 7:43 UTC (permalink / raw) To: netdev, linux-sh; +Cc: Magnus Damm, Sergei Shtylyov, devicetree Simply document new compat strings. As a previous patch adds a generic R-Car Gen2 compat string there appears to be no need for a driver updates. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt index 115006325bff..076accb652ad 100644 --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt @@ -5,6 +5,9 @@ interface. Required properties: - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. + "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. + "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. + "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. "renesas,etheravb-gen2" for generic R-Car Gen 2 compatible interface. -- 2.1.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-12-02 0:28 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-12-01 7:43 [PATCH 0/2 net-next] ravb: More compat strings Simon Horman 2015-12-01 7:43 ` [PATCH 1/2 net-next] ravb: Add fallback compatibility strings Simon Horman 2015-12-01 8:42 ` Geert Uytterhoeven 2015-12-02 0:28 ` Simon Horman 2015-12-01 10:26 ` Sergei Shtylyov 2015-12-02 0:27 ` Simon Horman 2015-12-01 7:43 ` [PATCH 2/2 net-next] ravb: Add device tree support for r8a779[123] Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).