devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Rob Herring <robh@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-mtd@lists.infradead.org, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Jonas Gorski <jogo@openwrt.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Kamal Dasu <kdasu.kdev@gmail.com>,
	Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding
Date: Wed, 2 Dec 2015 12:21:27 -0800	[thread overview]
Message-ID: <20151202202127.GN64635@google.com> (raw)
In-Reply-To: <565F50B0.4020802@simon.arlott.org.uk>

Hi Simon,

On Wed, Dec 02, 2015 at 08:12:32PM +0000, Simon Arlott wrote:
> On 02/12/15 20:00, Brian Norris wrote:
> > On Wed, Dec 02, 2015 at 07:41:07PM +0000, Simon Arlott wrote:
> >> I've created a bcm963268part driver so there won't need to be any
> >> partitions in DT for bcm63268.
> > 
> > Just curious, do you plan to submit this driver? We're working on
> 
> Yes, it's just the most recent one I've been working on. I still have
> USBH and IUDMA to submit
> 
> > matching up partition parsers to flash devices via device tree
> > of_match_table's, so you could do something like this:
> > 
> > 	nand0: nandcs@0 {
> > 		compatible = "brcm,nandcs";
> > 		...
> > 
> > 		partitions {
> > 			compatible = "brcm,bcm963268-partitions";
> > 			...
> > 		};
> > 	};
> 
> I modified brcmnand to look for a machine matching "brcm,bcm963268", but

Like this?

http://patchwork.ozlabs.org/patch/473180/

I'd like to avoid that (hence the "Rejected" status).

> that way is ok with me. Presumably "ofpart" defers to another matching
> partition parser?

Yes, "ofpart" is for specifying the entire partition table in the device
tree as subnodes of either the flash node or of the flash's "partitions"
subnode. It's not the most flexible, but it does work generically.

> Is there a patch for that method of parser detection available?

I have something working here, but I haven't had time to finish cleaning
it up and submitting it. There's an older patch that works similarly,
though it has some deficiencies:

http://patchwork.ozlabs.org/patch/475988/

The main difference between that and my (yet-to-be-submitted) proposal
is that I'd like parsers to opt in by adding a proper of_match_table
with non-Linux-specific DT bindings, and then we can drop the
"linux,..." naming and make it a reasonably generic property.

Regards,
Brian

  reply	other threads:[~2015-12-02 20:21 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21 13:10 [PATCH 1/2] mtd: brcmnand: Add brcm,nand-bcm63268 device tree binding Simon Arlott
     [not found] ` <56506D55.3000907-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org>
2015-11-21 13:12   ` [PATCH 2/2] mtd: brcmnand: Add support for BCM63268 interrupts Simon Arlott
2015-11-21 17:04     ` [PATCH 2/2 (v2)] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
     [not found]       ` <5650A402.7030404-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org>
2015-11-22 14:34         ` [PATCH (v3) 2/2] " Simon Arlott
2015-11-22 21:59 ` [PATCH 1/2] mtd: brcmnand: Add brcm,nand-bcm63268 device tree binding Rob Herring
2015-11-22 22:15   ` [PATCH (v4) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand " Simon Arlott
2015-11-22 22:17     ` [PATCH (v4) 2/2] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
2015-11-23 15:42       ` Jonas Gorski
2015-11-23 18:38         ` Simon Arlott
     [not found]       ` <56523EFF.9050502-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org>
2015-11-23 18:22         ` Florian Fainelli
2015-11-24  8:12           ` Simon Arlott
     [not found]             ` <56541BD3.4070202-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org>
2015-11-24 18:15               ` [PATCH (v5) " Simon Arlott
2015-11-24 18:41             ` [PATCH (v4) " Florian Fainelli
     [not found]               ` <5654AF69.7040901-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-11-24 20:19                 ` [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding Simon Arlott
2015-11-24 20:21                   ` [PATCH (v6) 2/2] mtd: brcmnand: Add support for the BCM63268 Simon Arlott
2015-11-25 10:44                     ` Jonas Gorski
2015-11-25 12:37                       ` Simon Arlott
2015-11-25 12:53                         ` Jonas Gorski
2015-11-25 19:49                           ` [PATCH (v7) " Simon Arlott
     [not found]                             ` <565610B9.5040407-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org>
2015-12-02 19:18                               ` Brian Norris
2015-12-02 19:54                                 ` Simon Arlott
2015-12-02 20:10                                   ` Brian Norris
2015-11-25 20:06                   ` [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding Rob Herring
     [not found]                   ` <afc6fb02d51a5378e315ade84a134eaf7a58a94f-dyyJQ+qCPjsfFgGGEbPnq5KvX+y0N6jJ2mWzQvkZbzCn6nfhxgf73RdaaeUjXGGo@public.gmane.org>
2015-12-02 19:05                     ` Brian Norris
     [not found]                       ` <20151202190555.GJ64635-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-12-02 19:36                         ` Jonas Gorski
2015-12-02 19:38                       ` Florian Fainelli
2015-12-02 20:02                         ` Simon Arlott
     [not found]                           ` <565F4E63.3030100-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org>
2015-12-02 21:44                             ` Florian Fainelli
2015-12-02 19:41                       ` Simon Arlott
2015-12-02 20:00                         ` Brian Norris
2015-12-02 20:12                           ` Simon Arlott
2015-12-02 20:21                             ` Brian Norris [this message]
2015-12-02 20:24                               ` Brian Norris
     [not found]                               ` <20151202202127.GN64635-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-12-02 20:34                                 ` Simon Arlott
2015-12-02 20:48                                   ` Brian Norris
     [not found]     ` <56523E85.905-qdVf85lJwsCyrPCCpiK2c/XRex20P6io@public.gmane.org>
2015-11-22 22:23       ` [PATCH (v4) " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202202127.GN64635@google.com \
    --to=computersforpeace@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=f.fainelli@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jogo@openwrt.org \
    --cc=kdasu.kdev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=simon@fire.lp0.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).