Re: [PATCHv6 4/5] devicetree: Add new ANX7814 SlimPort transmitter binding.

From: Rob Herring <robh@kernel.org>
To: Enric Balletbo i Serra <eballetbo@gmail.com>
Cc: mark.rutland@arm.com, sjoerd.simons@collabora.co.uk,
	laurent.pinchart@ideasonboard.com, devel@driverdev.osuosl.org,
	drinkcat@chromium.org, cawa.cheng@mediatek.com,
	nathan.chung@mediatek.com, javier@dowhile0.org,
	treding@nvidia.com, dan.carpenter@oracle.com,
	devicetree@vger.kernel.org, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, dri-devel@lists.freedesktop.org,
	eddie.huang@mediatek.com, cjiao@analogixsemi.com,
	jb.tsai@mediatek.com, gregkh@linuxfoundation.org,
	emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org,
	galak@codeaurora.org, span@analogixsemi.com
Subject: Re: [PATCHv6 4/5] devicetree: Add new ANX7814 SlimPort transmitter binding.
Date: Fri, 4 Dec 2015 10:13:58 -0600	[thread overview]
Message-ID: <20151204161358.GA6977@rob-hp-laptop> (raw)
In-Reply-To: <1449218107-6590-5-git-send-email-enric.balletbo@collabora.com>

On Fri, Dec 04, 2015 at 09:35:06AM +0100, Enric Balletbo i Serra wrote:
> The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter
> designed for portable devices.
> 
> You can add support to your board with current binding.
> 
> Example:
> 
> 	anx7814: anx7814@38 {
> 		compatible = "analogix,anx7814";
> 		reg = <0x38>;
> 		interrupt-parent = <&gpio0>
> 		interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> 		pd-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
> 		reset-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>;
> 		v10-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
> 		ports {

This and the example below should be just "port" I think. Otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> 			anx7814_in: endpoint {
> 				remote-endpoint = <&hdmi0_out>;
> 			};
> 		};
> 	};
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> 
> Changes since last version (requested by Rob Herring)
> - Specify how many ports and how many endpoints for each port
> - Simplify to just port (dropping ports)
> - For cable det use an interrupt instead (to a gpio controller)
> 
>  .../devicetree/bindings/video/bridge/anx7814.txt   | 39 ++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/video/bridge/anx7814.txt
> 
> diff --git a/Documentation/devicetree/bindings/video/bridge/anx7814.txt b/Documentation/devicetree/bindings/video/bridge/anx7814.txt
> new file mode 100644
> index 0000000..4e68789
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/bridge/anx7814.txt
> @@ -0,0 +1,39 @@
> +Analogix ANX7814 SlimPort (Full-HD Transmitter)
> +-----------------------------------------------
> +
> +The ANX7814 is an ultra-low power Full-HD (1080p60) SlimPort transmitter
> +designed for portable devices.
> +
> +Required properties:
> +
> + - compatible		: "analogix,anx7814"
> + - reg			: I2C address of the device
> + - interrupt-parent	: Should be the phandle of the interrupt controller
> +			  that services interrupts for this device
> + - interrupts		: Should contain the cable detection interrupt
> + - pd-gpios		: Which GPIO to use for power down
> + - reset-gpios		: Which GPIO to use for reset
> +
> +Optional properties:
> +
> + - v10-gpios		: Which GPIO to use for V10 control.
> + - Video port for HDMI output, using the DT bindings defined in [1].
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +
> +	anx7814: anx7814@38 {
> +		compatible = "analogix,anx7814";
> +		reg = <0x38>;
> +		interrupt-parent = <&gpio0>
> +		interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> +		pd-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>;
> +		v10-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
> +		ports {
> +			anx7814_in: endpoint {
> +				remote-endpoint = <&hdmi0_out>;
> +			};
> +		};
> +	};
> -- 
> 2.1.0
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel