From: Pavel Machek <pavel@ucw.cz>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] extcon: arizona: Update naming for micd-timeout DT to include units
Date: Fri, 4 Dec 2015 22:00:40 +0100 [thread overview]
Message-ID: <20151204210040.GC822@amd> (raw)
In-Reply-To: <1448290290-19267-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Mon 2015-11-23 14:51:30, Charles Keepax wrote:
> Add time units of -ms (milliseconds) to wlf,micd-timeout.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> .../devicetree/bindings/extcon/extcon-arizona.txt | 2 +-
> drivers/extcon/extcon-arizona.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> index da9813b..05d85ac 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> +++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> @@ -33,7 +33,7 @@ Optional properties:
> specified as per the ARIZONA_MICD_TIME_XXX defines.
> - wlf,micd-dbtime : Microphone detection hardware debounces specified as the
> number of measurements to take, valid values being 2 and 4.
> - - wlf,micd-timeout : Timeout for microphone detection, specified in
> + - wlf,micd-timeout-ms : Timeout for microphone detection, specified in
> milliseconds.
> - wlf,micd-force-micbias : Force MICBIAS continuously on during microphone
> detection.
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index c377030..8647533 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1230,7 +1230,7 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona)
> device_property_read_u32(arizona->dev, "wlf,micd-dbtime",
> &pdata->micd_dbtime);
>
> - device_property_read_u32(arizona->dev, "wlf,micd-timeout",
> + device_property_read_u32(arizona->dev, "wlf,micd-timeout-ms",
> &pdata->micd_timeout);
>
> pdata->micd_force_micbias =
device_property_read_bool(arizona->dev,
While the change is nice, new kernel is supposed to work with old
DTS. So you'd need to check for both properties here..
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-12-04 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 14:51 [PATCH] extcon: arizona: Update naming for micd-timeout DT to include units Charles Keepax
[not found] ` <1448290290-19267-1-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-11-24 0:04 ` Chanwoo Choi
2015-12-04 21:00 ` Pavel Machek [this message]
2015-12-07 1:31 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204210040.GC822@amd \
--to=pavel@ucw.cz \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).