From: David Miller <davem@davemloft.net>
To: preid@electromag.com.au
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
peppe.cavallaro@st.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] stmmac: socfpga: Provide dt node to config ptp clk source.
Date: Sun, 06 Dec 2015 23:04:10 -0500 (EST) [thread overview]
Message-ID: <20151206.230410.527597426769762516.davem@davemloft.net> (raw)
In-Reply-To: <1449452324-53858-3-git-send-email-preid@electromag.com.au>
From: Phil Reid <preid@electromag.com.au>
Date: Mon, 7 Dec 2015 09:38:40 +0800
> @@ -116,6 +118,9 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
> return -EINVAL;
> }
>
> + dwmac->f2h_ptp_ref_clk = of_property_read_bool(np, "f2h_ptp_ref_clk");
> +
> +
Too many empty lines.
> np_splitter = of_parse_phandle(np, "altr,emac-splitter", 0);
> if (np_splitter) {
> if (of_address_to_resource(np_splitter, 0, &res_splitter)) {
> @@ -171,6 +176,11 @@ static int socfpga_dwmac_setup(struct socfpga_dwmac *dwmac)
> ctrl &= ~(SYSMGR_EMACGRP_CTRL_PHYSEL_MASK << reg_shift);
> ctrl |= val << reg_shift;
>
> + if(dwmac->f2h_ptp_ref_clk)
Improperly formatted, there must be a space between the 'if' and the
openning parenthesis of the condition.
next prev parent reply other threads:[~2015-12-07 4:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 1:38 [PATCH v2 0/5] stmmac: Fixed Phy & PTP fixes Phil Reid
2015-12-07 1:38 ` [PATCH v2 1/5] stmmac: create of compatible mdio bus for stmacc driver Phil Reid
2015-12-07 1:38 ` [PATCH 1/1] stmmac: socfpga: Provide dt node to config ptp clk source Phil Reid
2015-12-07 4:04 ` David Miller [this message]
[not found] ` <1449452324-53858-3-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2015-12-07 11:57 ` Sergei Shtylyov
2015-12-07 1:38 ` [PATCH v2 2/5] stmmac: Correct documentation on stmmac clocks Phil Reid
2015-12-07 1:38 ` [PATCH v2 3/5] stmmac: Fix calculations for ptp counters when clock input = 50Mhz Phil Reid
2015-12-07 1:38 ` [PATCH v2 4/5] stmmac: Add ptp debugfs entry Phil Reid
[not found] ` <1449452324-53858-6-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2015-12-07 9:03 ` Arnd Bergmann
2015-12-07 13:37 ` Phil Reid
[not found] ` <56658BB0.10700-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2015-12-07 14:37 ` Arnd Bergmann
[not found] ` <1449452324-53858-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2015-12-07 1:38 ` [PATCH v2 5/5] stmmac: socfpga: Provide dt node to config ptp clk source Phil Reid
2015-12-07 9:05 ` Arnd Bergmann
2015-12-07 13:34 ` Phil Reid
2015-12-07 14:37 ` Arnd Bergmann
2015-12-07 11:59 ` Sergei Shtylyov
2015-12-07 13:31 ` Phil Reid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151206.230410.527597426769762516.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).