* [PATCH] of: fix build failure [not found] <20151203011814.GC5727@sirena.org.uk> @ 2015-12-03 8:38 ` Sudip Mukherjee 2015-12-05 11:09 ` Geert Uytterhoeven 0 siblings, 1 reply; 3+ messages in thread From: Sudip Mukherjee @ 2015-12-03 8:38 UTC (permalink / raw) To: Rob Herring, Frank Rowand, Grant Likely Cc: linux-kernel, devicetree, Mark Brown, linux-next, Sudip Mukherjee We are having build failure with next-20151202 for sparc allmodconfig with the error messages: undefined reference to 'of_io_request_and_map' CONFIG_OF is defined for sparc so it is expected that we have a definition of of_io_request_and_map() but of/address.c is only compiled if it is !SPARC. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport/builds/94541627 patch has been build tested with sparc allmodconfig and x86_64 allmodconfig. include/linux/of_address.h | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/include/linux/of_address.h b/include/linux/of_address.h index 507daad..7bf4603 100644 --- a/include/linux/of_address.h +++ b/include/linux/of_address.h @@ -112,8 +112,6 @@ static inline bool of_dma_is_coherent(struct device_node *np) extern int of_address_to_resource(struct device_node *dev, int index, struct resource *r); void __iomem *of_iomap(struct device_node *node, int index); -void __iomem *of_io_request_and_map(struct device_node *device, - int index, const char *name); #else #include <linux/io.h> @@ -136,6 +134,19 @@ static inline void __iomem *of_io_request_and_map(struct device_node *device, } #endif +#if defined(CONFIG_OF) && !defined(CONFIG_SPARC) +void __iomem *of_io_request_and_map(struct device_node *device, + int index, const char *name); +#else +#include <linux/io.h> + +static inline void __iomem *of_io_request_and_map(struct device_node *device, + int index, const char *name) +{ + return IOMEM_ERR_PTR(-EINVAL); +} +#endif /* CONFIG_OF && !CONFIG_SPARC */ + #if defined(CONFIG_OF_ADDRESS) && defined(CONFIG_PCI) extern const __be32 *of_get_pci_address(struct device_node *dev, int bar_no, u64 *size, unsigned int *flags); -- 1.9.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of: fix build failure 2015-12-03 8:38 ` [PATCH] of: fix build failure Sudip Mukherjee @ 2015-12-05 11:09 ` Geert Uytterhoeven 2015-12-07 6:36 ` Sudip Mukherjee 0 siblings, 1 reply; 3+ messages in thread From: Geert Uytterhoeven @ 2015-12-05 11:09 UTC (permalink / raw) To: Sudip Mukherjee Cc: Rob Herring, Frank Rowand, Grant Likely, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Brown, Linux-Next Hi Sudip On Thu, Dec 3, 2015 at 9:38 AM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > We are having build failure with next-20151202 for sparc allmodconfig > with the error messages: > undefined reference to 'of_io_request_and_map' > > CONFIG_OF is defined for sparc so it is expected that we have a > definition of of_io_request_and_map() but of/address.c is only compiled > if it is !SPARC. No, it's compiled depending on CONFIG_OF_ADDRESS... > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > > build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/builds/94541627 > > patch has been build tested with sparc allmodconfig and x86_64 > allmodconfig. > > include/linux/of_address.h | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/include/linux/of_address.h b/include/linux/of_address.h > index 507daad..7bf4603 100644 > --- a/include/linux/of_address.h > +++ b/include/linux/of_address.h > @@ -112,8 +112,6 @@ static inline bool of_dma_is_coherent(struct device_node *np) > extern int of_address_to_resource(struct device_node *dev, int index, > struct resource *r); > void __iomem *of_iomap(struct device_node *node, int index); > -void __iomem *of_io_request_and_map(struct device_node *device, > - int index, const char *name); > #else > > #include <linux/io.h> > @@ -136,6 +134,19 @@ static inline void __iomem *of_io_request_and_map(struct device_node *device, > } > #endif > > +#if defined(CONFIG_OF) && !defined(CONFIG_SPARC) ... hence wouldn't it be better to use "#ifdef CONFIG_OF_ADDRESS" instead? > +void __iomem *of_io_request_and_map(struct device_node *device, > + int index, const char *name); > +#else > +#include <linux/io.h> > + > +static inline void __iomem *of_io_request_and_map(struct device_node *device, > + int index, const char *name) > +{ > + return IOMEM_ERR_PTR(-EINVAL); > +} > +#endif /* CONFIG_OF && !CONFIG_SPARC */ > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: fix build failure 2015-12-05 11:09 ` Geert Uytterhoeven @ 2015-12-07 6:36 ` Sudip Mukherjee 0 siblings, 0 replies; 3+ messages in thread From: Sudip Mukherjee @ 2015-12-07 6:36 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Rob Herring, Frank Rowand, Grant Likely, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Brown, Linux-Next On Sat, Dec 05, 2015 at 12:09:41PM +0100, Geert Uytterhoeven wrote: > Hi Sudip > > On Thu, Dec 3, 2015 at 9:38 AM, Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: > > We are having build failure with next-20151202 for sparc allmodconfig > > with the error messages: > > undefined reference to 'of_io_request_and_map' > > > > CONFIG_OF is defined for sparc so it is expected that we have a > > definition of of_io_request_and_map() but of/address.c is only compiled > > if it is !SPARC. > > No, it's compiled depending on CONFIG_OF_ADDRESS... yes, ofcourse. I did it looking at: config OF_ADDRESS def_bool y depends on !SPARC && HAS_IOMEM > > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > --- <snip> > > +#if defined(CONFIG_OF) && !defined(CONFIG_SPARC) > > ... hence wouldn't it be better to use "#ifdef CONFIG_OF_ADDRESS" instead? > I will test with today's next and send v2. regards sudip ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-07 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151203011814.GC5727@sirena.org.uk>
2015-12-03 8:38 ` [PATCH] of: fix build failure Sudip Mukherjee
2015-12-05 11:09 ` Geert Uytterhoeven
2015-12-07 6:36 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).