From: Rob Herring <robh@kernel.org>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kumar Gala <galak@codeaurora.org>,
Thierry Reding <treding@nvidia.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 2/3] dt-bindings: add Silicon Image SiI8620 bridge bindings
Date: Tue, 8 Dec 2015 21:47:47 -0600 [thread overview]
Message-ID: <20151209034747.GA19896@rob-hp-laptop> (raw)
In-Reply-To: <1449582546-18667-3-git-send-email-a.hajda@samsung.com>
On Tue, Dec 08, 2015 at 02:49:05PM +0100, Andrzej Hajda wrote:
> SiI8620 transmitter converts eTMDS/HDMI signal to MHL 3.0. It is controlled
> via I2C bus.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> .../bindings/video/bridge/sil-sii8620.txt | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt
>
> diff --git a/Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt b/Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt
> new file mode 100644
> index 0000000..29f3f35
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/bridge/sil-sii8620.txt
> @@ -0,0 +1,34 @@
> +Silicon Image SiI8620 bridge bindings
Bridging what to what?
> +
> +Required properties:
> + - compatible: "sil,sii8620"
> + - reg: i2c address of the bridge
> + - cvcc10-supply: Digital Core Supply Voltage (1.0V)
> + - iovcc18-supply: I/O Supply Voltage (1.8V)
> + - int-gpios: gpio specifier of INT pin
Assuming INT means interrupt, this should use interrupts property.
> + - reset-gpios: gpio specifier of RESET pin
> + - clocks, clock-names: specification and name of "xtal" clock
> + - video interfaces: Device node can contain video interface port
> + node for HDMI encoder according to [1].
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> + sii8620@39 {
> + reg = <0x39>;
> + compatible = "sil,sii8620";
> + cvcc10-supply = <&ldo36_reg>;
> + iovcc18-supply = <&ldo34_reg>;
> + int-gpio = <&gpf0 2 0>;
> + reset-gpio = <&gpv7 0 0>;
> + clocks = <&pmu_system_controller 0>;
> + clock-names = "xtal";
> + assigned-clocks = <&pmu_system_controller 0>;
> + assigned-clock-parents = <&xxti>;
These aren't listed in the doc.
> +
> + port {
> + mhl_to_hdmi: endpoint {
> + remote-endpoint = <&hdmi_to_mhl>;
> + };
> + };
I'd like to see this have a port to a connector node, too. Possibly
that can come later.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-09 3:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 13:49 [PATCH 0/3] drm/bridge: add Silicon Image SiI8620 driver Andrzej Hajda
2015-12-08 13:49 ` [PATCH 1/3] video: add header file for Mobile High-Definition Link (MHL) interface Andrzej Hajda
2015-12-08 13:49 ` [PATCH 2/3] dt-bindings: add Silicon Image SiI8620 bridge bindings Andrzej Hajda
2015-12-09 3:47 ` Rob Herring [this message]
2015-12-09 9:58 ` Andrzej Hajda
2015-12-09 21:54 ` Rob Herring
2015-12-08 13:49 ` [PATCH 3/3] drm/bridge: add Silicon Image SiI8620 driver Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209034747.GA19896@rob-hp-laptop \
--to=robh@kernel.org \
--cc=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kyungmin.park@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox