From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string
Date: Wed, 9 Dec 2015 15:42:04 +0900 [thread overview]
Message-ID: <20151209064158.GA9037@verge.net.au> (raw)
In-Reply-To: <87io48rvce.wl%kuninori.morimoto.gx@renesas.com>
On Wed, Dec 09, 2015 at 06:29:07AM +0000, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent
> > > > with what I documented elsewhere in the patch)
> > >
> > > "renesas,rcar-usbhs" is better,
> > > but I guess you want to have "renesas,rcar-gen2-usbhs" ?
> > >
> > > My understanding is these
> > >
> > > * renesas,usbhs-r8a77xx # SoC specific
> > > * renesas,rcar-usbhs # R-Car common
> > > * renesas,rcar-gen2-usbhs # R-Car Gen2 common
> > > * renesas,rcar-gen3-usbhs # R-Car Gen3 common
> > > * renesas,usbhs # Renesas USBHS common
> > >
> >
> > I was intentionally including gen3 as well. So I think we have two options:
> >
> > 1. renesas,rcar-usbhs
> > 2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs
>
> Renesas USB always have pick feature/settings.
> Thus, generic name (= "renesas,rcar-usbhs") is very risky IMO.
> I think 2 is more safety.
Sure, better safe than sorry.
next prev parent reply other threads:[~2015-12-09 6:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 5:51 [PATCH 0/2] usb: renesas_usbhs: More compat strings Simon Horman
[not found] ` <1449553911-21412-1-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-08 5:51 ` [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string Simon Horman
[not found] ` <1449553911-21412-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-08 6:05 ` Kuninori Morimoto
[not found] ` <87egex5vfl.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2015-12-08 7:49 ` Simon Horman
2015-12-08 8:32 ` Kuninori Morimoto
[not found] ` <87a8pl5oms.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2015-12-09 2:37 ` Simon Horman
2015-12-09 4:48 ` Kuninori Morimoto
2015-12-09 5:30 ` Simon Horman
[not found] ` <20151209052957.GA20831-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-09 6:29 ` Kuninori Morimoto
2015-12-09 6:42 ` Simon Horman [this message]
2015-12-08 14:35 ` Sergei Shtylyov
[not found] ` <5666EAB0.6000109-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-12-09 2:37 ` Simon Horman
2015-12-08 5:51 ` [PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23] Simon Horman
[not found] ` <1449553911-21412-3-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-12-09 3:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209064158.GA9037@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).