From: Mark Brown <broonie@kernel.org>
To: Damien Horsley <Damien.Horsley@imgtec.com>
Cc: alsa-devel@alsa-project.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
James Hartley <james.hartley@imgtec.com>
Subject: Re: [PATCH V3 2/2] ASoC: img: Add driver for Pistachio internal DAC
Date: Wed, 9 Dec 2015 20:17:35 +0000 [thread overview]
Message-ID: <20151209201735.GH5727@sirena.org.uk> (raw)
In-Reply-To: <1449678609-5592-3-git-send-email-Damien.Horsley@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On Wed, Dec 09, 2015 at 04:30:09PM +0000, Damien Horsley wrote:
> +static const struct snd_kcontrol_new pistachio_internal_dac_snd_controls[] = {
> + SOC_SINGLE("Mute Switch", PISTACHIO_INTERNAL_DAC_CTRL, 2, 1, 0)
> +};
This would normally be called "Playback Switch" and (presumably) have
the opposite sense - this is a standard name that applications know and
will be able to use automatically.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-12-09 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 16:30 [PATCH V3 0/2] Add support for Pistachio internal DAC Damien Horsley
2015-12-09 16:30 ` [PATCH V3 1/2] ASoC: img: Add binding document " Damien Horsley
2015-12-09 16:30 ` [PATCH V3 2/2] ASoC: img: Add driver " Damien Horsley
2015-12-09 20:17 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151209201735.GH5727@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Damien.Horsley@imgtec.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=james.hartley@imgtec.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).