[PATCH v3 0/3] usb: renesas_usbhs: More compat strings

[PATCH v3 0/3] usb: renesas_usbhs: More compat strings

[Simon Horman]

Hi,

this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
strings to the Renesas USBHS driver. The intention is to provide a complete
set of compat strings for known R-Car SoCs.

Changes since v2:
* Split documentation of SoC names into separate patch
* Use correct fallback compatibility string in example

Changes since v1:
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
  a single compatibility string for all of R-Car.

Simon Horman (3):
  usb: renesas_usbhs: add SoC names to compatibility string
    documentation
  usb: renesas_usbhs: add fallback compatibility strings
  usb: renesas_usbhs: add device tree support for r8a779[23]

 .../devicetree/bindings/usb/renesas_usbhs.txt        | 20 +++++++++++++++-----
 drivers/usb/renesas_usbhs/common.c                   |  9 +++++++++
 2 files changed, 24 insertions(+), 5 deletions(-)

-- 
2.1.4

[PATCH v3 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

[Simon Horman]

This extends the documentation of compatibility strings a little to
include the SoC names.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
v3
* Split into separate patch
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 7d48f63db44e..a14c0bb561d5 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -2,10 +2,10 @@ Renesas Electronics USBHS driver
 
 Required properties:
   - compatible: Must contain one of the following:
-	- "renesas,usbhs-r8a7790"
-	- "renesas,usbhs-r8a7791"
-	- "renesas,usbhs-r8a7794"
-	- "renesas,usbhs-r8a7795"
+	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
+	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
+	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
   - reg: Base address and length of the register for the USBHS
   - interrupts: Interrupt specifier for the USBHS
   - clocks: A list of phandle + clock specifier pairs
-- 
2.1.4

[PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

Add fallback compatibility strings for R-Car Gen2 and Gen3.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
---
v3
* Moved documentation of SoC names to a separate patch
* Use correct fallback compatibility string in example

v2
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
  a single compatibility string for all of R-Car.
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 +++++++++-
 drivers/usb/renesas_usbhs/common.c                      |  9 +++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index a14c0bb561d5..c55cf77006d0 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
 
 Required properties:
   - compatible: Must contain one of the following:
+
 	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
 	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
 	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
 	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
+	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
+	- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
+
+	When compatible with the generic version, nodes must list the
+	SoC-specific version corresponding to the platform first followed
+	by the generic version.
+
   - reg: Base address and length of the register for the USBHS
   - interrupts: Interrupt specifier for the USBHS
   - clocks: A list of phandle + clock specifier pairs
@@ -22,7 +30,7 @@ Optional properties:
 
 Example:
 	usbhs: usb@e6590000 {
-		compatible = "renesas,usbhs-r8a7790";
+		compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs";
 		reg = <0 0xe6590000 0 0x100>;
 		interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
 		clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index d82fa36c3465..db9a17bd8997 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
 		.compatible = "renesas,usbhs-r8a7795",
 		.data = (void *)USBHS_TYPE_RCAR_GEN2,
 	},
+	{
+		.compatible = "renesas,rcar-gen2-usbhs",
+		.data = (void *)USBHS_TYPE_RCAR_GEN2,
+	},
+	{
+		/* Gen3 is compatible with Gen2 */
+		.compatible = "renesas,rcar-gen3-usbhs",
+		.data = (void *)USBHS_TYPE_RCAR_GEN2,
+	},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, usbhs_of_match);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 3/3] usb: renesas_usbhs: add device tree support for r8a779[23]

[Simon Horman]

Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index c55cf77006d0..471a0649e63e 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -5,6 +5,8 @@ Required properties:
 
 	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
 	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+	- "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
+	- "renesas,usbhs-r8a7793" for r8a7793 (R-Car M2-N) compatible device
 	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
 	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
 	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/3] usb: renesas_usbhs: More compat strings

[Kuninori Morimoto]

Hi

> this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
> strings to the Renesas USBHS driver. The intention is to provide a complete
> set of compat strings for known R-Car SoCs.
> 
> Changes since v2:
> * Split documentation of SoC names into separate patch
> * Use correct fallback compatibility string in example
> 
> Changes since v1:
> * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
>   a single compatibility string for all of R-Car.
> 
> Simon Horman (3):
>   usb: renesas_usbhs: add SoC names to compatibility string
>     documentation
>   usb: renesas_usbhs: add fallback compatibility strings
>   usb: renesas_usbhs: add device tree support for r8a779[23]
> 
>  .../devicetree/bindings/usb/renesas_usbhs.txt        | 20 +++++++++++++++-----
>  drivers/usb/renesas_usbhs/common.c                   |  9 +++++++++
>  2 files changed, 24 insertions(+), 5 deletions(-)

For all patches

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Re: [PATCH v3 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

[Rob Herring]

On Fri, Dec 11, 2015 at 11:12:25AM +0900, Simon Horman wrote:
> This extends the documentation of compatibility strings a little to
> include the SoC names.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Acked-by: Rob Herring <robh@kernel.org>

> ---
> v3
> * Split into separate patch
> ---
>  Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index 7d48f63db44e..a14c0bb561d5 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -2,10 +2,10 @@ Renesas Electronics USBHS driver
>  
>  Required properties:
>    - compatible: Must contain one of the following:
> -	- "renesas,usbhs-r8a7790"
> -	- "renesas,usbhs-r8a7791"
> -	- "renesas,usbhs-r8a7794"
> -	- "renesas,usbhs-r8a7795"
> +	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> +	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> +	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
> +	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
>    - reg: Base address and length of the register for the USBHS
>    - interrupts: Interrupt specifier for the USBHS
>    - clocks: A list of phandle + clock specifier pairs
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Rob Herring]

On Fri, Dec 11, 2015 at 11:12:26AM +0900, Simon Horman wrote:
> Add fallback compatibility strings for R-Car Gen2 and Gen3.
> This is in keeping with the fallback scheme being adopted wherever
> appropriate for drivers for Renesas SoCs.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Binding looks okay, but one possible typo.

Acked-by: Rob Herring <robh@kernel.org>

> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
>  		.compatible = "renesas,usbhs-r8a7795",
>  		.data = (void *)USBHS_TYPE_RCAR_GEN2,
>  	},
> +	{
> +		.compatible = "renesas,rcar-gen2-usbhs",
> +		.data = (void *)USBHS_TYPE_RCAR_GEN2,
> +	},
> +	{
> +		/* Gen3 is compatible with Gen2 */
> +		.compatible = "renesas,rcar-gen3-usbhs",
> +		.data = (void *)USBHS_TYPE_RCAR_GEN2,

This supposed to be GEN3?

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

On Thu, Dec 10, 2015 at 09:56:24PM -0600, Rob Herring wrote:
> On Fri, Dec 11, 2015 at 11:12:26AM +0900, Simon Horman wrote:
> > Add fallback compatibility strings for R-Car Gen2 and Gen3.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Binding looks okay, but one possible typo.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> > @@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
> >  		.compatible = "renesas,usbhs-r8a7795",
> >  		.data = (void *)USBHS_TYPE_RCAR_GEN2,
> >  	},
> > +	{
> > +		.compatible = "renesas,rcar-gen2-usbhs",
> > +		.data = (void *)USBHS_TYPE_RCAR_GEN2,
> > +	},
> > +	{
> > +		/* Gen3 is compatible with Gen2 */
> > +		.compatible = "renesas,rcar-gen3-usbhs",
> > +		.data = (void *)USBHS_TYPE_RCAR_GEN2,
> 
> This supposed to be GEN3?

Confusingly the symbol is called GEN2 as it was there for Gen 2
before Gen 3 came along and (so far) Gen 3 is compatible with Gen 2.

I'd be happy to change the name but I think that would be best
as an incremental change on top of this one.

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Sergei Shtylyov]

Hello.

On 12/11/2015 5:12 AM, Simon Horman wrote:

> Add fallback compatibility strings for R-Car Gen2 and Gen3.
> This is in keeping with the fallback scheme being adopted wherever
> appropriate for drivers for Renesas SoCs.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> v3
> * Moved documentation of SoC names to a separate patch
> * Use correct fallback compatibility string in example
>
> v2
> * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
>    a single compatibility string for all of R-Car.
> ---
>   Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 +++++++++-
>   drivers/usb/renesas_usbhs/common.c                      |  9 +++++++++
>   2 files changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index a14c0bb561d5..c55cf77006d0 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
>
>   Required properties:
>     - compatible: Must contain one of the following:

    Really?

> +
>   	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
>   	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
>   	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
>   	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
> +	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
> +	- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
> +
> +	When compatible with the generic version, nodes must list the
> +	SoC-specific version corresponding to the platform first followed
> +	by the generic version.
> +

    This kinda contradicts the above claim.

[...]

MBR, Sergei

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

On Fri, Dec 11, 2015 at 03:24:27PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/11/2015 5:12 AM, Simon Horman wrote:
> 
> >Add fallback compatibility strings for R-Car Gen2 and Gen3.
> >This is in keeping with the fallback scheme being adopted wherever
> >appropriate for drivers for Renesas SoCs.
> >
> >Signed-off-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
> >---
> >v3
> >* Moved documentation of SoC names to a separate patch
> >* Use correct fallback compatibility string in example
> >
> >v2
> >* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
> >   a single compatibility string for all of R-Car.
> >---
> >  Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 +++++++++-
> >  drivers/usb/renesas_usbhs/common.c                      |  9 +++++++++
> >  2 files changed, 18 insertions(+), 1 deletion(-)
> >
> >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >index a14c0bb561d5..c55cf77006d0 100644
> >--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >@@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
> >
> >  Required properties:
> >    - compatible: Must contain one of the following:
> 
>    Really?

Would "...one or more of the following" help?

> >+
> >  	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> >  	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> >  	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
> >  	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
> >+	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
> >+	- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
> >+
> >+	When compatible with the generic version, nodes must list the
> >+	SoC-specific version corresponding to the platform first followed
> >+	by the generic version.
> >+
> 
>    This kinda contradicts the above claim.
> 
> [...]
> 
> MBR, Sergei
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Geert Uytterhoeven]

On Tue, Dec 15, 2015 at 7:41 AM, Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote:
>> >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >index a14c0bb561d5..c55cf77006d0 100644
>> >--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>> >@@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
>> >
>> >  Required properties:
>> >    - compatible: Must contain one of the following:
>>
>>    Really?
>
> Would "...one or more of the following" help?

+1

>> >+
>> >     - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
>> >     - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
>> >     - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
>> >     - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
>> >+    - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
>> >+    - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
>> >+
>> >+    When compatible with the generic version, nodes must list the
>> >+    SoC-specific version corresponding to the platform first followed
>> >+    by the generic version.
>> >+
>>
>>    This kinda contradicts the above claim.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Sergei Shtylyov]

Hello.

On 12/15/2015 9:41 AM, Simon Horman wrote:

>>> Add fallback compatibility strings for R-Car Gen2 and Gen3.
>>> This is in keeping with the fallback scheme being adopted wherever
>>> appropriate for drivers for Renesas SoCs.
>>>
>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>> ---
>>> v3
>>> * Moved documentation of SoC names to a separate patch
>>> * Use correct fallback compatibility string in example
>>>
>>> v2
>>> * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
>>>    a single compatibility string for all of R-Car.
>>> ---
>>>   Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 +++++++++-
>>>   drivers/usb/renesas_usbhs/common.c                      |  9 +++++++++
>>>   2 files changed, 18 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>>> index a14c0bb561d5..c55cf77006d0 100644
>>> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>>> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
>>> @@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
>>>
>>>   Required properties:
>>>     - compatible: Must contain one of the following:
>>
>>     Really?
>
> Would "...one or more of the following" help?

    It would, of course.

>>> +
>>>   	- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
>>>   	- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
>>>   	- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
>>>   	- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
>>> +	- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
>>> +	- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
>>> +
>>> +	When compatible with the generic version, nodes must list the
>>> +	SoC-specific version corresponding to the platform first followed
>>> +	by the generic version.
>>> +
>>
>>     This kinda contradicts the above claim.
>>
>> [...]

MBR, Sergei

Re: [PATCH v3 0/3] usb: renesas_usbhs: More compat strings

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]


Hi,

Simon Horman <horms+renesas@verge.net.au> writes:
> Hi,
>
> this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
> strings to the Renesas USBHS driver. The intention is to provide a complete
> set of compat strings for known R-Car SoCs.
>
> Changes since v2:
> * Split documentation of SoC names into separate patch
> * Use correct fallback compatibility string in example
>
> Changes since v1:
> * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
>   a single compatibility string for all of R-Car.
>
> Simon Horman (3):
>   usb: renesas_usbhs: add SoC names to compatibility string
>     documentation
>   usb: renesas_usbhs: add fallback compatibility strings
>   usb: renesas_usbhs: add device tree support for r8a779[23]

since patch 2 got a few comments, I'll wait a new series. While
resending, please collect all Acks to ease my life a bit ;-)

cheers

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]