From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 3/7] ARM: hisi: add dt_machine definition for Hi3519 Date: Fri, 11 Dec 2015 09:21:06 -0600 Message-ID: <20151211152106.GB21272@rob-hp-laptop> References: <1449819921-18464-1-git-send-email-xuejiancheng@huawei.com> <1449819921-18464-4-git-send-email-xuejiancheng@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1449819921-18464-4-git-send-email-xuejiancheng@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Jiancheng Xue Cc: mturquette@baylibre.com, sboyd@codeaurora.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, khilman@linaro.org, arnd@arndb.de, olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, bintian.wang@huawei.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yanhaifeng@hisilicon.com, yanghongwei@hisilicon.com, suwenping@hisilicon.com, ml.yang@hisilicon.com, gaofei@hisilicon.com, zhangzhenxing@hisilicon.com, xuejiancheng@hisilicon.com List-Id: devicetree@vger.kernel.org On Fri, Dec 11, 2015 at 03:45:17PM +0800, Jiancheng Xue wrote: > add dt_machine definition for hi3519. > > Signed-off-by: Jiancheng Xue > --- > arch/arm/mach-hisi/hisilicon.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/mach-hisi/hisilicon.c b/arch/arm/mach-hisi/hisilicon.c > index 8cc6215..010d8a2 100644 > --- a/arch/arm/mach-hisi/hisilicon.c > +++ b/arch/arm/mach-hisi/hisilicon.c > @@ -81,3 +81,12 @@ static const char *const hip01_compat[] __initconst = { > DT_MACHINE_START(HIP01, "Hisilicon HIP01 (Flattened Device Tree)") > .dt_compat = hip01_compat, > MACHINE_END > + > +static const char *const hi3519_compat[] __initconst = { > + "hisilicon,hi3519", > + NULL, > +}; You should just have 1 mach desc with multiple compatible strings to match against, not 1 mach desc per compatible string. Rob > + > +DT_MACHINE_START(HI3519_DT, "Hisilicon Hi3519") > + .dt_compat = hi3519_compat, > +MACHINE_END > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html