public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH v2] ARM: dts: imx7d: cl-som-imx7: add basic module support
Date: Mon, 14 Dec 2015 10:43:15 +0800	[thread overview]
Message-ID: <20151214024315.GC25756@tiger> (raw)
In-Reply-To: <1449756097-2921-1-git-send-email-grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>

On Thu, Dec 10, 2015 at 04:01:37PM +0200, Igor Grinberg wrote:
> From: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> 
> CL-SOM-iMX7 is a miniature System-on-Module (SoM) based on
> Freescale i.MX7 System-on-Chip family.
> 
> http://www.compulab.co.il/products/computer-on-modules/cl-som-imx7-freescale-i-mx-7-system-on-module/
> 
> Add basic DT support for standalone module (without a carrier board):
> 
> * Memory configuration
> * I2C2 bus
> * PMIC
> * UART1
> 
> Signed-off-by: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> Signed-off-by: Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> 
> v2: use generic node name for pmic (Thanks Rob).
> 
>  arch/arm/boot/dts/Makefile                    |   1 +
>  arch/arm/boot/dts/imx7d-cl-som-imx7.dts       | 150 ++++++++++++++++++++++++++
>  3 files changed, 155 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
> index 34c88b0..30b0ba1 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.txt
> +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> @@ -53,6 +53,10 @@ i.MX6 Quad SABRE Automotive Board
>  Required root node properties:
>      - compatible = "fsl,imx6q-sabreauto", "fsl,imx6q";
>  
> +i.MX7D CL-SOM-iMX7 Board
> +Required root node properties:
> +    - compatible = "compulab,cl-som-imx7", "fsl,imx7d";
> +

This is not a board produced by FSL, so it should be documented in
fsl.txt.

>  Generic i.MX boards
>  -------------------
>  
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 30bbc37..83ed521 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -350,6 +350,7 @@ dtb-$(CONFIG_SOC_IMX6SX) += \
>  dtb-$(CONFIG_SOC_IMX6UL) += \
>  	imx6ul-14x14-evk.dtb
>  dtb-$(CONFIG_SOC_IMX7D) += \
> +	imx7d-cl-som-imx7.dtb \
>  	imx7d-sdb.dtb
>  dtb-$(CONFIG_SOC_LS1021A) += \
>  	ls1021a-qds.dtb \
> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> new file mode 100644
> index 0000000..ba05198
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> @@ -0,0 +1,150 @@
> +/*
> + * Support for CompuLab CL-SOM-iMX7 System-on-Module
> + *
> + * Copyright (C) 2015 CompuLab Ltd. - http://www.compulab.co.il/
> + * Author: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published by
> + * the Free Software Foundation.
> + */

GPL/X11 dual licence is generally suggested for newly added dts files,
as it will let non-Linux OS use them.

> +
> +/dts-v1/;
> +
> +#include <dt-bindings/input/input.h>
> +#include "imx7d.dtsi"
> +
> +/ {
> +	model = "CompuLab CL-SOM-iMX7";
> +	compatible = "compulab,cl-som-imx7", "fsl,imx7d";
> +
> +	memory {
> +		reg = <0x80000000 0x10000000>; /* 256 MB - minimal configuration */
> +	};
> +};
> +
> +&cpu0 {
> +	arm-supply = <&sw1a_reg>;
> +};
> +
> +&i2c2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c2>;
> +	status = "okay";
> +
> +	pmic: pmic@8 {
> +		compatible = "fsl,pfuze3000";
> +		reg = <0x08>;
> +
> +		regulators {
> +			sw1a_reg: sw1a {
> +				regulator-min-microvolt = <700000>;
> +				regulator-max-microvolt = <1475000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <6250>;
> +			};
> +
> +			/* use sw1c_reg to align with pfuze100/pfuze200 */
> +			sw1c_reg: sw1b {
> +				regulator-min-microvolt = <700000>;
> +				regulator-max-microvolt = <1475000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <6250>;
> +			};
> +
> +			sw2_reg: sw2 {
> +				regulator-min-microvolt = <1500000>;
> +				regulator-max-microvolt = <1850000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			sw3a_reg: sw3 {
> +				regulator-min-microvolt = <900000>;
> +				regulator-max-microvolt = <1650000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			swbst_reg: swbst {
> +				regulator-min-microvolt = <5000000>;
> +				regulator-max-microvolt = <5150000>;
> +			};
> +
> +			snvs_reg: vsnvs {
> +				regulator-min-microvolt = <1000000>;
> +				regulator-max-microvolt = <3000000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			vref_reg: vrefddr {
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			vgen1_reg: vldo1 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen2_reg: vldo2 {
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <1550000>;
> +			};
> +
> +			vgen3_reg: vccsd {
> +				regulator-min-microvolt = <2850000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen4_reg: v33 {
> +				regulator-min-microvolt = <2850000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen5_reg: vldo3 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen6_reg: vldo4 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +		};
> +	};
> +};
> +
> +&uart1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart1>;
> +	assigned-clocks = <&clks IMX7D_UART1_ROOT_SRC>;
> +	assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
> +	status = "okay";
> +};
> +
> +&iomuxc {
> +	cl-som-imx7 {

Since commit (5fcdf6a7ed95 pinctrl: imx: Allow parsing DT without
function nodes), this level of container node is not really needed any
more.

Shawn

> +		pinctrl_i2c2: i2c2grp {
> +			fsl,pins = <
> +				MX7D_PAD_I2C2_SDA__I2C2_SDA		0x4000007f
> +				MX7D_PAD_I2C2_SCL__I2C2_SCL		0x4000007f
> +			>;
> +		};
> +
> +		pinctrl_uart1: uart1grp {
> +			fsl,pins = <
> +				MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX	0x79
> +				MX7D_PAD_UART1_RX_DATA__UART1_DCE_RX	0x79
> +			>;
> +		};
> +	};
> +};
> -- 
> 2.4.10
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-12-14  2:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07  7:14 [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Ilya Ledvich
     [not found] ` <1449472479-2521-1-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-07  7:14   ` [PATCH 1/8] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
     [not found]     ` <1449472479-2521-2-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-08 15:14       ` Rob Herring
2015-12-10 14:01         ` [PATCH v2] " Igor Grinberg
     [not found]           ` <1449756097-2921-1-git-send-email-grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-14  2:43             ` Shawn Guo [this message]
2015-12-16 14:01               ` Igor Grinberg
     [not found]                 ` <56716EA4.2080107-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-21  6:36                   ` Shawn Guo
2015-12-21  8:07                     ` Igor Grinberg
     [not found]                       ` <5677B341.6040203-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-21 13:54                         ` Shawn Guo
2015-12-21 13:59                         ` Shawn Guo
2015-12-22  7:38                           ` Igor Grinberg
2015-12-07  7:14   ` [PATCH 2/8] ARM: dts: imx7d: cl-som-imx7: add usb otg support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 3/8] ARM: dts: imx7d: cl-som-imx7: add eMMC support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 4/8] ARM: dts: imx7d: cl-som-imx7: add fec1 support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 5/8] ARM: dts: imx7d: cl-som-imx7: add eeprom support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 6/8] ARM: dts: imx7d: cl-som-imx7: add gpio extender support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 7/8] ARM: dts: imx7d: cl-som-imx7: add fec2 support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 8/8] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
     [not found]     ` <1449472479-2521-9-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-08 15:16       ` Rob Herring
2015-12-14  2:47   ` [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-16 14:09     ` Igor Grinberg
     [not found]       ` <5671707E.5000908-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-21  6:41         ` Shawn Guo
2015-12-21  7:54           ` Igor Grinberg
2015-12-22  8:15   ` [PATCH v2 0/2] " Ilya Ledvich
     [not found]     ` <1450772120-18131-1-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-22  8:15       ` [PATCH v2 1/2] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
     [not found]         ` <1450772120-18131-2-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-22 12:17           ` Shawn Guo
2015-12-22 14:07             ` Igor Grinberg
2015-12-22  8:15       ` [PATCH v2 2/2] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
     [not found]         ` <1450772120-18131-3-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-22 12:19           ` Shawn Guo
2015-12-22 14:13             ` Igor Grinberg
2015-12-22 12:13       ` [PATCH v2 0/2] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-22 14:14         ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151214024315.GC25756@tiger \
    --to=shawnguo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox