[PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl

[PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl

[Bai Ping]

The 'assigned-clock-parents' and 'assigned-clock-rates' list
should corresponding to the 'assigned-clocks' property clock list.

Signed-off-by: Bai Ping <b51503@freescale.com>
---
 arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
index 5a26173..dd92279 100644
--- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
@@ -113,14 +113,14 @@
 &clks {
 	assigned-clocks = <&clks IMX6QDL_PLL4_BYPASS_SRC>,
 			  <&clks IMX6QDL_PLL4_BYPASS>,
-			  <&clks IMX6QDL_CLK_PLL4_POST_DIV>,
 			  <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
-			  <&clks IMX6QDL_CLK_LDB_DI1_SEL>;
+			  <&clks IMX6QDL_CLK_LDB_DI1_SEL>,
+			  <&clks IMX6QDL_CLK_PLL4_POST_DIV>;
 	assigned-clock-parents = <&clks IMX6QDL_CLK_LVDS2_IN>,
 				 <&clks IMX6QDL_PLL4_BYPASS_SRC>,
 				 <&clks IMX6QDL_CLK_PLL3_USB_OTG>,
 				 <&clks IMX6QDL_CLK_PLL3_USB_OTG>;
-	assigned-clock-rates = <0>, <0>, <24576000>;
+	assigned-clock-rates = <0>, <0>, <0>, <0>, <24576000>;
 };
 
 &ecspi1 {
-- 
1.9.1

Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl

[Shawn Guo]

On Wed, Dec 09, 2015 at 04:15:55PM +0800, Bai Ping wrote:
> The 'assigned-clock-parents' and 'assigned-clock-rates' list
> should corresponding to the 'assigned-clocks' property clock list.
> 
> Signed-off-by: Bai Ping <b51503@freescale.com>

Applied, thanks.

Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl

[Shawn Guo]

On Mon, Dec 14, 2015 at 11:07:50AM +0800, Shawn Guo wrote:
> On Wed, Dec 09, 2015 at 04:15:55PM +0800, Bai Ping wrote:
> > The 'assigned-clock-parents' and 'assigned-clock-rates' list
> > should corresponding to the 'assigned-clocks' property clock list.
> > 
> > Signed-off-by: Bai Ping <b51503@freescale.com>
> 
> Applied, thanks.

As this essentially a fix to ed339363de1b ("ARM: dts: imx6qdl-sabreauto:
Allow HDMI and LVDS to work simultaneously"), I'm going to send it as a
fix with copying stable.

@Fabio,

Do you agree with the fix?

Shawn

Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl

[Fabio Estevam]

On Tue, Dec 15, 2015 at 6:52 AM, Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Mon, Dec 14, 2015 at 11:07:50AM +0800, Shawn Guo wrote:
>> On Wed, Dec 09, 2015 at 04:15:55PM +0800, Bai Ping wrote:
>> > The 'assigned-clock-parents' and 'assigned-clock-rates' list
>> > should corresponding to the 'assigned-clocks' property clock list.
>> >
>> > Signed-off-by: Bai Ping <b51503-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>
>> Applied, thanks.
>
> As this essentially a fix to ed339363de1b ("ARM: dts: imx6qdl-sabreauto:
> Allow HDMI and LVDS to work simultaneously"), I'm going to send it as a
> fix with copying stable.

Actually the mismatch exists since 97dae8590fa314c ("ARM: dts:
imx6qdl-sabreauto: Add audio support").

> @Fabio,
>
> Do you agree with the fix?

It seems that even after this patch we still have a mismatch:
assigned-clocks has 5 members and assigned-clock-parents has 4.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl

[Bai Ping]

On 2015/12/15 19:16, Fabio Estevam wrote:
> On Tue, Dec 15, 2015 at 6:52 AM, Shawn Guo <shawnguo@kernel.org> wrote:
>> On Mon, Dec 14, 2015 at 11:07:50AM +0800, Shawn Guo wrote:
>>> On Wed, Dec 09, 2015 at 04:15:55PM +0800, Bai Ping wrote:
>>>> The 'assigned-clock-parents' and 'assigned-clock-rates' list
>>>> should corresponding to the 'assigned-clocks' property clock list.
>>>>
>>>> Signed-off-by: Bai Ping <b51503@freescale.com>
>>> Applied, thanks.
>> As this essentially a fix to ed339363de1b ("ARM: dts: imx6qdl-sabreauto:
>> Allow HDMI and LVDS to work simultaneously"), I'm going to send it as a
>> fix with copying stable.
> Actually the mismatch exists since 97dae8590fa314c ("ARM: dts:
> imx6qdl-sabreauto: Add audio support").
>
>> @Fabio,
>>
>> Do you agree with the fix?
> It seems that even after this patch we still have a mismatch:
> assigned-clocks has 5 members and assigned-clock-parents has 4.
I think if it is the last clock in the assigned-clock list, the 
corresponding
'assigned-clock-parents' and 'assigned-clock-rates'  entry can be omitted.

BR
Jacky Bai

Re: [PATCH] ARM: dts: imx: Fix the assigned-clock mismatch issue on imx6q/dl

[Fabio Estevam]

On Tue, Dec 15, 2015 at 10:25 AM, Bai Ping <b51503-KZfg59tc24xl57MIdRCFDg@public.gmane.org> wrote:

>> It seems that even after this patch we still have a mismatch:
>> assigned-clocks has 5 members and assigned-clock-parents has 4.
>
> I think if it is the last clock in the assigned-clock list, the
> corresponding
> 'assigned-clock-parents' and 'assigned-clock-rates'  entry can be omitted.

Yes, you are right. Confirmed with
Documentation/devicetree/bindings/clock/clock-bindings.txt and your
patch is correct, thanks:

Reviewed-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html