From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 01/16] serial: sh-sci: Drop the interface clock Date: Mon, 14 Dec 2015 17:15:40 +0900 Message-ID: <20151214081540.GD9929@verge.net.au> References: <1447958173-543-1-git-send-email-geert+renesas@glider.be> <1447958173-543-2-git-send-email-geert+renesas@glider.be> <20151213064237.GA16326@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151213064237.GA16326@kroah.com> Sender: linux-sh-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Geert Uytterhoeven , Magnus Damm , Yoshinori Sato , Laurent Pinchart , linux-serial@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Greg, On Sat, Dec 12, 2015 at 10:42:37PM -0800, Greg Kroah-Hartman wrote: > On Thu, Nov 19, 2015 at 07:35:58PM +0100, Geert Uytterhoeven wrote: > > From: Laurent Pinchart > > > > As no platform defines an interface clock the SCI driver always falls > > back to a clock named "peripheral_clk". > > - On SH platforms that clock is the base clock for the SCI functional > > clock and has the same frequency, > > - On ARM platforms that clock doesn't exist, and clk_get() will return > > the default clock for the device. > > We can thus make the functional clock mandatory and drop the interface > > clock. > > > > EPROBE_DEFER is handled for clocks that may be referenced from DT (i.e. > > "fck" and deprecated "sci_ick"). > > > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Laurent Pinchart > > Acked-by: Simon Horman > > [geert: Handle EPROBE_DEFER, reformat description, break long comment line] > > Signed-off-by: Geert Uytterhoeven > > Acked-by: Greg Kroah-Hartman If its not too much trouble I would prefer if you took this into the serial tree.