From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH for-4.4 2/2] doc: dt: mtd: partitions: add compatible property to "partitions" node Date: Mon, 14 Dec 2015 11:35:15 -0800 Message-ID: <20151214193515.GC10460@google.com> References: <1449194529-145705-1-git-send-email-computersforpeace@gmail.com> <1449194529-145705-2-git-send-email-computersforpeace@gmail.com> <20151207175835.GM120110@google.com> <20151209011256.GV120110@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Jonas Gorski , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Suchanek , Boris Brezillon , Simon Arlott , Rob Herring , MTD Maling List , Sebastian Hesselbarth , Gregory Clement List-Id: devicetree@vger.kernel.org On Mon, Dec 14, 2015 at 03:49:14PM +0100, Geert Uytterhoeven wrote: > On Wed, Dec 9, 2015 at 2:12 AM, Brian Norris > wrote: > > On Mon, Dec 07, 2015 at 09:58:35AM -0800, Brian Norris wrote: > >> On Sat, Dec 05, 2015 at 12:45:36PM +0100, Jonas Gorski wrote: > >> > On Fri, Dec 4, 2015 at 3:02 AM, Brian Norris > >> > wrote: > >> > > // proposed > >> > > partitions { > >> > > compatible = "partitions"; > >> > > >> > "partitions" sounds mode like a device_type thing than a compatible > >> > name, maybe "fixed-partitions"? IMHO that would describe better what > >> > these are, and doesn't invite to think using compatible = > >> > "arm,arm-flash-structure", "partitions"; is a good idea. > >> > >> "fixed-partitions" sounds OK to me. If no objections, I'll apply these > >> patches, with (approximately) a: > >> > >> s/"partitions"/"fixed-partitions"/ > > > > Pushed to linux-mtd.git with the above change. > > Aarghl, hadn't seen this patch before. > > This breaks the users that have already added the partitions subnodes > (armada-xp-lenovo-ix4-300d.dts and a few shmobile). Sorry, I checked Linus' master and not linux-next :( > Will send patches to fix it... Thanks. Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html