* [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes
@ 2015-12-15 14:36 Jisheng Zhang
2015-12-15 14:43 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Jisheng Zhang @ 2015-12-15 14:36 UTC (permalink / raw)
To: sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, catalin.marinas-5wv7dgnIgG8,
will.deacon-5wv7dgnIgG8
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Jisheng Zhang
Commit ac82d1277215 ("arm64: perf: add Cortex-A53 support") adds the
cortex A53 PMU support, thus instead of using the generic armv8-pmuv3
compatibility use the more specific Cortex A53 compatibility.
Signed-off-by: Jisheng Zhang <jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
---
arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
index 099ad93..e48d424 100644
--- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
+++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
@@ -115,7 +115,7 @@
};
pmu {
- compatible = "arm,armv8-pmuv3";
+ compatible = "arm,cortex-a53-pmu";
interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
--
2.6.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes
2015-12-15 14:36 [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes Jisheng Zhang
@ 2015-12-15 14:43 ` Arnd Bergmann
2015-12-15 14:47 ` Jisheng Zhang
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2015-12-15 14:43 UTC (permalink / raw)
To: Jisheng Zhang
Cc: sebastian.hesselbarth, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, catalin.marinas, will.deacon, devicetree,
linux-arm-kernel, linux-kernel
On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote:
> - compatible = "arm,armv8-pmuv3";
> + compatible = "arm,cortex-a53-pmu";
>
Should this list both?
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes
2015-12-15 14:43 ` Arnd Bergmann
@ 2015-12-15 14:47 ` Jisheng Zhang
2015-12-15 14:52 ` Mark Rutland
0 siblings, 1 reply; 4+ messages in thread
From: Jisheng Zhang @ 2015-12-15 14:47 UTC (permalink / raw)
To: Arnd Bergmann, sebastian.hesselbarth, mark.rutland
Cc: robh+dt, pawel.moll, ijc+devicetree, galak, catalin.marinas,
will.deacon, devicetree, linux-arm-kernel, linux-kernel
Dear Arnd,
On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote:
> On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote:
> > - compatible = "arm,armv8-pmuv3";
> > + compatible = "arm,cortex-a53-pmu";
> >
>
> Should this list both?
IMHO, we don't need to list both. The pmu binding document also says:
"compatible : should be one of ...."
Dear Mark,
Could you please give suggestions?
Thanks,
Jisheng
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes
2015-12-15 14:47 ` Jisheng Zhang
@ 2015-12-15 14:52 ` Mark Rutland
0 siblings, 0 replies; 4+ messages in thread
From: Mark Rutland @ 2015-12-15 14:52 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Arnd Bergmann, sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, catalin.marinas-5wv7dgnIgG8,
will.deacon-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Tue, Dec 15, 2015 at 10:47:09PM +0800, Jisheng Zhang wrote:
> Dear Arnd,
>
> On Tue, 15 Dec 2015 15:43:53 +0100 Arnd Bergmann wrote:
>
> > On Tuesday 15 December 2015 22:36:12 Jisheng Zhang wrote:
> > > - compatible = "arm,armv8-pmuv3";
> > > + compatible = "arm,cortex-a53-pmu";
> > >
> >
> > Should this list both?
>
> IMHO, we don't need to list both. The pmu binding document also says:
> "compatible : should be one of ...."
>
> Dear Mark,
>
> Could you please give suggestions?
That should probably reads as "should contain at least one of".
It's probably best to keep "arm,armv8-pmuv3" as a fallback in the
compatible list.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-15 14:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-15 14:36 [PATCH] arm64: dts: berlin4ct: switch to Cortex-A53 specific pmu nodes Jisheng Zhang
2015-12-15 14:43 ` Arnd Bergmann
2015-12-15 14:47 ` Jisheng Zhang
2015-12-15 14:52 ` Mark Rutland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).