From: Richard Cochran <richardcochran@gmail.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH v3] net/macb: add support for resetting PHY using GPIO
Date: Wed, 16 Dec 2015 20:04:31 +0100 [thread overview]
Message-ID: <20151216190431.GB28759@localhost.localdomain> (raw)
In-Reply-To: <1450290690-32369-1-git-send-email-gregory.clement@free-electrons.com>
On Wed, Dec 16, 2015 at 07:31:30PM +0100, Gregory CLEMENT wrote:
> +Optional properties for PHY child node:
> +- reset-gpios : Should specify the gpio for phy reset
reset-gpios plural or reset-gpio singular?
> +
> Examples:
>
> macb0: ethernet@fffc4000 {
> @@ -29,4 +32,8 @@ Examples:
> local-mac-address = [3a 0e 03 04 05 06];
> clock-names = "pclk", "hclk", "tx_clk";
> clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>;
> + ethernet-phy@1 {
> + reg = <0x1>;
> + reset-gpios = <&pioE 6 1>;
Did you mean "gpioE" ?
Thanks,
Richard
next prev parent reply other threads:[~2015-12-16 19:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 18:31 [PATCH v3] net/macb: add support for resetting PHY using GPIO Gregory CLEMENT
2015-12-16 19:04 ` Richard Cochran [this message]
2015-12-16 19:09 ` Gregory CLEMENT
[not found] ` <1450290690-32369-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-16 19:10 ` Arnd Bergmann
2015-12-17 8:39 ` Gregory CLEMENT
[not found] ` <874mfhtqnv.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-17 9:51 ` [PATCH] net/macb: Update device tree binding " Gregory CLEMENT
[not found] ` <1450345864-10907-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-12-17 20:53 ` David Miller
2015-12-17 16:59 ` [PATCH v3] net/macb: add support " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216190431.GB28759@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=s.hauer@pengutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).