From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH v2 2/8] irq: bcm2836: Add SMP support for the 2836 Date: Thu, 17 Dec 2015 07:17:42 +0200 Message-ID: <20151217051742.GV2318@tarshish> References: <1450310115-22163-1-git-send-email-eric@anholt.net> <1450310115-22163-3-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1450310115-22163-3-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Eric Anholt Cc: Mark Rutland , devicetree@vger.kernel.org, Florian Fainelli , Jason Cooper , Scott Branden , Ian Campbell , Marc Zyngier , Ray Jui , Stephen Warren , linux-kernel@vger.kernel.org, Lee Jones , Andrea Merello , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Kumar Gala , Thomas Gleixner , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Eric, On Wed, Dec 16, 2015 at 03:55:09PM -0800, Eric Anholt wrote: > @@ -226,6 +228,26 @@ static const struct irq_domain_ops bcm2836_arm_irqchip_intc_ops = { > .xlate = irq_domain_xlate_onecell > }; > > +#ifdef CONFIG_SMP Why not put this section under the existing '#ifdef CONFIG_SMP' just a few lines above? > +int __init bcm2836_smp_boot_secondary(unsigned int cpu, > + struct task_struct *idle) > +{ > + unsigned long secondary_startup_phys = > + (unsigned long)virt_to_phys((void *)secondary_startup); > + > + dsb(); > + writel(secondary_startup_phys, > + intc.base + LOCAL_MAILBOX3_SET0 + 16 * cpu); > + > + return 0; > +} > + > +static const struct smp_operations bcm2836_smp_ops __initconst = { > + .smp_boot_secondary = bcm2836_smp_boot_secondary, > +}; > + > +#endif baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -