Re: [PATCH v3 6/9] phy: ti-pipe3: use *syscon* framework API to power on/off the PHY

Kishon Vijay Abraham I
2015-12-21T08:36:27Z

Hi

On Sunday 20 December 2015 09:08 AM, Rob Herring wrote:
> On Tue, Dec 15, 2015 at 02:46:05PM +0530, Kishon Vijay Abraham I wrote:
>> Deprecate using phy-omap-control driver to power on/off the PHY and
>> use *syscon* framework to do the same.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>> Documentation/devicetree/bindings/phy/ti-phy.txt | 10 ++-
>> drivers/phy/phy-ti-pipe3.c | 90 ++++++++++++++++++----
>> 2 files changed, 85 insertions(+), 15 deletions(-)
>
> For the binding:
>
> Acked-by: Rob Herring <robh@kernel.org>
>
> One comment on the driver though.
>
> [...]
>
>> --- a/drivers/phy/phy-ti-pipe3.c
>> +++ b/drivers/phy/phy-ti-pipe3.c
>
> [...]
>
>> @@ -144,18 +155,53 @@ static void ti_pipe3_disable_clocks(struct ti_pipe3 *phy);
>>
>> static int ti_pipe3_power_off(struct phy *x)
>> {
>> + u32 val;
>> + int ret;
>> struct ti_pipe3 *phy = phy_get_drvdata(x);
>>
>> - omap_control_phy_power(phy->control_dev, 0);
>> + if (phy->phy_power_syscon) {
>
> Writing this as:
>
> if (!phy->phy_power_syscon) {
> ...
> return 0;
> }
>
> //regmap code
>
>
> will make it simpler to remove the deprecated code later.

hmm.. I will make this change in all the applicable patches.

Thanks
Kishon
>
>
>> + val = PIPE3_PHY_TX_RX_POWEROFF <<
>> + PIPE3_PHY_PWRCTL_CLK_CMD_SHIFT;
>> +
>> + ret = regmap_update_bits(phy->phy_power_syscon, phy->power_reg,
>> + PIPE3_PHY_PWRCTL_CLK_CMD_MASK, val);
>> + if (ret < 0)
>> + return ret;
>> + } else {
>> + omap_control_phy_power(phy->control_dev, 0);
>> + }
>>
>> return 0;