devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx7d: cl-som-imx7: add basic module support
Date: Tue, 22 Dec 2015 20:17:18 +0800	[thread overview]
Message-ID: <20151222121718.GB26290@tiger> (raw)
In-Reply-To: <1450772120-18131-2-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>

On Tue, Dec 22, 2015 at 10:15:19AM +0200, Ilya Ledvich wrote:
> CL-SOM-iMX7 is a miniature System-on-Module (SoM) based on
> Freescale i.MX7 System-on-Chip family.
> 
> http://www.compulab.co.il/products/computer-on-modules/cl-som-imx7-freescale-i-mx-7-system-on-module/
> 
> Add basic DT support for standalone module (without a carrier board):
> 
> * Memory configuration
> * eMMC
> * 2x Gigabit Ethernet ports (FEC1 and FEC2)
> * I2C2 bus
>   * EEPROM
>   * PCA9555 GPIO extender
>   * PMIC
> * UART1
> * USB OTG port
> 
> Signed-off-by: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> Signed-off-by: Igor Grinberg <grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> ---
> 
> v2: use generic node name for pmic (Thanks Rob)
>     move board description out of fsl.txt (Shawn)
>     use GPL/X11 dual licence for newly added dts files (Shawn)
>     discard one level of container node (Shawn)
>     squash several patches into one patch (Shawn)
> 
>  arch/arm/boot/dts/Makefile              |   1 +
>  arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 293 ++++++++++++++++++++++++++++++++
>  2 files changed, 294 insertions(+)
>  create mode 100644 arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 30bbc37..83ed521 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -350,6 +350,7 @@ dtb-$(CONFIG_SOC_IMX6SX) += \
>  dtb-$(CONFIG_SOC_IMX6UL) += \
>  	imx6ul-14x14-evk.dtb
>  dtb-$(CONFIG_SOC_IMX7D) += \
> +	imx7d-cl-som-imx7.dtb \
>  	imx7d-sdb.dtb
>  dtb-$(CONFIG_SOC_LS1021A) += \
>  	ls1021a-qds.dtb \
> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> new file mode 100644
> index 0000000..1ec4528
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> @@ -0,0 +1,293 @@
> +/*
> + * Support for CompuLab CL-SOM-iMX7 System-on-Module
> + *
> + * Copyright (C) 2015 CompuLab Ltd. - http://www.compulab.co.il/
> + * Author: Ilya Ledvich <ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/input/input.h>
> +#include "imx7d.dtsi"
> +
> +/ {
> +	model = "CompuLab CL-SOM-iMX7";
> +	compatible = "compulab,cl-som-imx7", "fsl,imx7d";
> +
> +	memory {
> +		reg = <0x80000000 0x10000000>; /* 256 MB - minimal configuration */
> +	};
> +
> +	regulators {
> +		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;

DT maintainers dislike this fake "simple-bus" container, and we were
asked to put fixed regulator directly under root.  I fixed it up like
below:

	reg_usb_otg1_vbus: regulator-vbus {
		compatible = "regulator-fixed";
		regulator-name = "usb_otg1_vbus";
		regulator-min-microvolt = <5000000>;
		regulator-max-microvolt = <5000000>;
		gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
		enable-active-high;
	};

Shawn

> +
> +		reg_usb_otg1_vbus: regulator@0 {
> +			compatible = "regulator-fixed";
> +			reg = <0>;
> +			regulator-name = "usb_otg1_vbus";
> +			regulator-min-microvolt = <5000000>;
> +			regulator-max-microvolt = <5000000>;
> +			gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> +			enable-active-high;
> +		};
> +	};
> +};
> +
> +&cpu0 {
> +	arm-supply = <&sw1a_reg>;
> +};
> +
> +&fec1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_enet1>;
> +	assigned-clocks = <&clks IMX7D_ENET1_TIME_ROOT_SRC>,
> +			  <&clks IMX7D_ENET1_TIME_ROOT_CLK>;
> +	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
> +	assigned-clock-rates = <0>, <100000000>;
> +	phy-mode = "rgmii";
> +	phy-handle = <&ethphy0>;
> +	fsl,magic-packet;
> +	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@0 {
> +			reg = <0>;
> +		};
> +
> +		ethphy1: ethernet-phy@1 {
> +			reg = <1>;
> +		};
> +	};
> +};
> +
> +&fec2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_enet2>;
> +	assigned-clocks = <&clks IMX7D_ENET2_TIME_ROOT_SRC>,
> +			  <&clks IMX7D_ENET2_TIME_ROOT_CLK>;
> +	assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
> +	assigned-clock-rates = <0>, <100000000>;
> +	phy-mode = "rgmii";
> +	phy-handle = <&ethphy1>;
> +	fsl,magic-packet;
> +	status = "okay";
> +};
> +
> +&i2c2 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_i2c2>;
> +	status = "okay";
> +
> +	pmic: pmic@8 {
> +		compatible = "fsl,pfuze3000";
> +		reg = <0x08>;
> +
> +		regulators {
> +			sw1a_reg: sw1a {
> +				regulator-min-microvolt = <700000>;
> +				regulator-max-microvolt = <1475000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <6250>;
> +			};
> +
> +			/* use sw1c_reg to align with pfuze100/pfuze200 */
> +			sw1c_reg: sw1b {
> +				regulator-min-microvolt = <700000>;
> +				regulator-max-microvolt = <1475000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <6250>;
> +			};
> +
> +			sw2_reg: sw2 {
> +				regulator-min-microvolt = <1500000>;
> +				regulator-max-microvolt = <1850000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			sw3a_reg: sw3 {
> +				regulator-min-microvolt = <900000>;
> +				regulator-max-microvolt = <1650000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			swbst_reg: swbst {
> +				regulator-min-microvolt = <5000000>;
> +				regulator-max-microvolt = <5150000>;
> +			};
> +
> +			snvs_reg: vsnvs {
> +				regulator-min-microvolt = <1000000>;
> +				regulator-max-microvolt = <3000000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			vref_reg: vrefddr {
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			vgen1_reg: vldo1 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen2_reg: vldo2 {
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <1550000>;
> +			};
> +
> +			vgen3_reg: vccsd {
> +				regulator-min-microvolt = <2850000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen4_reg: v33 {
> +				regulator-min-microvolt = <2850000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen5_reg: vldo3 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +
> +			vgen6_reg: vldo4 {
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-always-on;
> +			};
> +		};
> +	};
> +
> +	pca9555: pca9555@20 {
> +		compatible = "nxp,pca9555";
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		reg = <0x20>;
> +	};
> +
> +	eeprom@50 {
> +		compatible = "atmel,24c08";
> +		reg = <0x50>;
> +		pagesize = <16>;
> +	};
> +};
> +
> +&uart1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_uart1>;
> +	assigned-clocks = <&clks IMX7D_UART1_ROOT_SRC>;
> +	assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
> +	status = "okay";
> +};
> +
> +&usbotg1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usbotg1>;
> +	vbus-supply = <&reg_usb_otg1_vbus>;
> +	status = "okay";
> +};
> +
> +&usdhc3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_usdhc3>;
> +	assigned-clocks = <&clks IMX7D_USDHC3_ROOT_CLK>;
> +	assigned-clock-rates = <400000000>;
> +	bus-width = <8>;
> +	fsl,tuning-step = <2>;
> +	non-removable;
> +	status = "okay";
> +};
> +
> +&iomuxc {
> +	pinctrl_enet1: enet1grp {
> +		fsl,pins = <
> +			MX7D_PAD_SD2_CD_B__ENET1_MDIO			0x3
> +			MX7D_PAD_SD2_WP__ENET1_MDC			0x3
> +			MX7D_PAD_ENET1_RGMII_TXC__ENET1_RGMII_TXC	0x1
> +			MX7D_PAD_ENET1_RGMII_TD0__ENET1_RGMII_TD0	0x1
> +			MX7D_PAD_ENET1_RGMII_TD1__ENET1_RGMII_TD1	0x1
> +			MX7D_PAD_ENET1_RGMII_TD2__ENET1_RGMII_TD2	0x1
> +			MX7D_PAD_ENET1_RGMII_TD3__ENET1_RGMII_TD3	0x1
> +			MX7D_PAD_ENET1_RGMII_TX_CTL__ENET1_RGMII_TX_CTL	0x1
> +			MX7D_PAD_ENET1_RGMII_RXC__ENET1_RGMII_RXC	0x1
> +			MX7D_PAD_ENET1_RGMII_RD0__ENET1_RGMII_RD0	0x1
> +			MX7D_PAD_ENET1_RGMII_RD1__ENET1_RGMII_RD1	0x1
> +			MX7D_PAD_ENET1_RGMII_RD2__ENET1_RGMII_RD2	0x1
> +			MX7D_PAD_ENET1_RGMII_RD3__ENET1_RGMII_RD3	0x1
> +			MX7D_PAD_ENET1_RGMII_RX_CTL__ENET1_RGMII_RX_CTL	0x1
> +		>;
> +	};
> +
> +	pinctrl_enet2: enet2grp {
> +		fsl,pins = <
> +			MX7D_PAD_EPDC_GDSP__ENET2_RGMII_TXC		0x1
> +			MX7D_PAD_EPDC_SDCE2__ENET2_RGMII_TD0		0x1
> +			MX7D_PAD_EPDC_SDCE3__ENET2_RGMII_TD1		0x1
> +			MX7D_PAD_EPDC_GDCLK__ENET2_RGMII_TD2		0x1
> +			MX7D_PAD_EPDC_GDOE__ENET2_RGMII_TD3		0x1
> +			MX7D_PAD_EPDC_GDRL__ENET2_RGMII_TX_CTL		0x1
> +			MX7D_PAD_EPDC_SDCE1__ENET2_RGMII_RXC		0x1
> +			MX7D_PAD_EPDC_SDCLK__ENET2_RGMII_RD0		0x1
> +			MX7D_PAD_EPDC_SDLE__ENET2_RGMII_RD1		0x1
> +			MX7D_PAD_EPDC_SDOE__ENET2_RGMII_RD2		0x1
> +			MX7D_PAD_EPDC_SDSHR__ENET2_RGMII_RD3		0x1
> +			MX7D_PAD_EPDC_SDCE0__ENET2_RGMII_RX_CTL		0x1
> +		>;
> +	};
> +
> +	pinctrl_i2c2: i2c2grp {
> +		fsl,pins = <
> +			MX7D_PAD_I2C2_SDA__I2C2_SDA		0x4000007f
> +			MX7D_PAD_I2C2_SCL__I2C2_SCL		0x4000007f
> +		>;
> +	};
> +
> +	pinctrl_uart1: uart1grp {
> +		fsl,pins = <
> +			MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX	0x79
> +			MX7D_PAD_UART1_RX_DATA__UART1_DCE_RX	0x79
> +		>;
> +	};
> +
> +	pinctrl_usbotg1: usbotg1grp {
> +		fsl,pins = <
> +			MX7D_PAD_GPIO1_IO05__GPIO1_IO5		0x14 /* OTG PWREN */
> +		>;
> +	};
> +
> +	pinctrl_usdhc3: usdhc3grp {
> +		fsl,pins = <
> +			MX7D_PAD_SD3_CMD__SD3_CMD		0x59
> +			MX7D_PAD_SD3_CLK__SD3_CLK		0x19
> +			MX7D_PAD_SD3_DATA0__SD3_DATA0		0x59
> +			MX7D_PAD_SD3_DATA1__SD3_DATA1		0x59
> +			MX7D_PAD_SD3_DATA2__SD3_DATA2		0x59
> +			MX7D_PAD_SD3_DATA3__SD3_DATA3		0x59
> +			MX7D_PAD_SD3_DATA4__SD3_DATA4		0x59
> +			MX7D_PAD_SD3_DATA5__SD3_DATA5		0x59
> +			MX7D_PAD_SD3_DATA6__SD3_DATA6		0x59
> +			MX7D_PAD_SD3_DATA7__SD3_DATA7		0x59
> +			MX7D_PAD_SD3_STROBE__SD3_STROBE		0x19
> +		>;
> +	};
> +};
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-12-22 12:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07  7:14 [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Ilya Ledvich
     [not found] ` <1449472479-2521-1-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-07  7:14   ` [PATCH 1/8] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
     [not found]     ` <1449472479-2521-2-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-08 15:14       ` Rob Herring
2015-12-10 14:01         ` [PATCH v2] " Igor Grinberg
     [not found]           ` <1449756097-2921-1-git-send-email-grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-14  2:43             ` Shawn Guo
2015-12-16 14:01               ` Igor Grinberg
     [not found]                 ` <56716EA4.2080107-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-21  6:36                   ` Shawn Guo
2015-12-21  8:07                     ` Igor Grinberg
     [not found]                       ` <5677B341.6040203-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-21 13:54                         ` Shawn Guo
2015-12-21 13:59                         ` Shawn Guo
2015-12-22  7:38                           ` Igor Grinberg
2015-12-07  7:14   ` [PATCH 2/8] ARM: dts: imx7d: cl-som-imx7: add usb otg support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 3/8] ARM: dts: imx7d: cl-som-imx7: add eMMC support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 4/8] ARM: dts: imx7d: cl-som-imx7: add fec1 support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 5/8] ARM: dts: imx7d: cl-som-imx7: add eeprom support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 6/8] ARM: dts: imx7d: cl-som-imx7: add gpio extender support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 7/8] ARM: dts: imx7d: cl-som-imx7: add fec2 support Ilya Ledvich
2015-12-07  7:14   ` [PATCH 8/8] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
     [not found]     ` <1449472479-2521-9-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-08 15:16       ` Rob Herring
2015-12-14  2:47   ` [PATCH 0/8] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-16 14:09     ` Igor Grinberg
     [not found]       ` <5671707E.5000908-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-21  6:41         ` Shawn Guo
2015-12-21  7:54           ` Igor Grinberg
2015-12-22  8:15   ` [PATCH v2 0/2] " Ilya Ledvich
     [not found]     ` <1450772120-18131-1-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-22  8:15       ` [PATCH v2 1/2] ARM: dts: imx7d: cl-som-imx7: add basic module support Ilya Ledvich
     [not found]         ` <1450772120-18131-2-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-22 12:17           ` Shawn Guo [this message]
2015-12-22 14:07             ` Igor Grinberg
2015-12-22  8:15       ` [PATCH v2 2/2] ARM: dts: imx7d: sbc-imx7: add basic board support Ilya Ledvich
     [not found]         ` <1450772120-18131-3-git-send-email-ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
2015-12-22 12:19           ` Shawn Guo
2015-12-22 14:13             ` Igor Grinberg
2015-12-22 12:13       ` [PATCH v2 0/2] Add support for CL-SOM-iMX7 and SBC-iMX7 Shawn Guo
2015-12-22 14:14         ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151222121718.GB26290@tiger \
    --to=shawnguo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=ilya-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).