From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support Date: Wed, 23 Dec 2015 07:36:31 -0800 Message-ID: <20151223153630.GK2793@atomide.com> References: <1450859744-9948-1-git-send-email-uri.mashiach@compulab.co.il> <1450859744-9948-3-git-send-email-uri.mashiach@compulab.co.il> <567A76B5.70605@ti.com> <567AB1CB.1050203@compulab.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <567AB1CB.1050203-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Uri Mashiach Cc: Grygorii Strashko , Kalle Valo , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, Igor Grinberg , Eliad Peller , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org * Uri Mashiach [151223 06:38]: > On 12/23/2015 12:25 PM, Grygorii Strashko wrote: > > >>+ that services interrupts for this device > >>+- vwlan-supply : Point the node of the regulator that controls the wl1271 chip WLAN_EN pin > > > >Pls, use gpio if this is required just to toggle WLAN_EN pin. > > > >[ti,] power-gpio or en-gpio > > > > > > The controller's power might need toggling in some board implementation. > Maybe GPIO and regulator should be implemented? Yes a regulator for wlcore is best here because to properly control it and the wait needed. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html