From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v3 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Date: Sun, 27 Dec 2015 22:20:59 +0100 Message-ID: <20151227212059.GN30359@lukather> References: <1450445451-311-1-git-send-email-vishnupatekar0510@gmail.com> <1450445451-311-3-git-send-email-vishnupatekar0510@gmail.com> <20151218214112.GU30359@lukather> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cU9XODsizZBnwgll" Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Vishnu Patekar Cc: "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Jonathan Corbet , "pawel.moll-5wv7dgnIgG8@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , Kumar Gala , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , Emilio Lopez , Linus Walleij , Jens Kuske , Hans de Goede , Chen-Yu Tsai , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --cU9XODsizZBnwgll Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Tue, Dec 22, 2015 at 05:41:22PM +0800, Vishnu Patekar wrote: > >> + clocks { > >> + #address-cells = <1>; > >> + #size-cells = <1>; > >> + ranges; > >> + > >> + osc24M: osc24M_clk { > >> + #clock-cells = <0>; > >> + compatible = "fixed-clock"; > >> + clock-frequency = <24000000>; > >> + clock-output-names = "osc24M"; > >> + }; > >> + > >> + osc32k: osc32k_clk { > >> + #clock-cells = <0>; > >> + compatible = "fixed-clock"; > >> + clock-frequency = <32768>; > >> + clock-output-names = "osc32k"; > >> + }; > > > > Do you need to modify the clocks driver in your first commit then? > I did not get what you are trying to say here, could you please elaborate? > > I'll correct mistakes, and re-send this patch, is it okie? In your first patch, you add a CLK_OF_DECLARE for the H3 compatible in clk-sunxi.c Judging from your clocks node above, you don't need it at all. I'm guessing you'll need it later on, but I wanted to know if that was intentional :) Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --cU9XODsizZBnwgll--