From: Rob Herring <robh@kernel.org>
To: "David Rivshin (Allworx)" <drivshin.allworx@gmail.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
David Miller <davem@davemloft.net>, Heiko Schocher <hs@denx.de>,
Mugunthan V N <mugunthanvnm@ti.com>,
Markus Brunner <systemprogrammierung.brunner@gmail.com>,
Pascal Speck <kernel@iktek.de>,
Daniel Trautmann <dtrautmann@ibhsoftec-sps.de>
Subject: Re: [PATCH 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property
Date: Tue, 29 Dec 2015 14:30:34 -0600 [thread overview]
Message-ID: <20151229203034.GA18528@rob-hp-laptop> (raw)
In-Reply-To: <1450830994-5450-3-git-send-email-drivshin.allworx@gmail.com>
On Tue, Dec 22, 2015 at 07:36:33PM -0500, David Rivshin (Allworx) wrote:
> From: David Rivshin <drivshin@allworx.com>
>
> The phy-handle, phy_id, and fixed-link properties are mutually exclusive,
> and only one need be specified. However if phy-handle was specified, an
> error message would complain about the lack of phy_id or fixed-link.
>
> Also, if phy-handle was specified and the subsequent of_phy_connect()
> failed, the error message still referenced slaved->data->phy_id, which
> would be empty. Instead, use the name of the device_node as a useful
> identifier.
>
> Fixes: 9e42f715264f ("drivers: net: cpsw: add phy-handle parsing")
> Signed-off-by: David Rivshin <drivshin@allworx.com>
> ---
> This would require some adjustments to backport to 4.3-stable due to
> other changes in this area. Let me know if you want a version of this
> against v4.3.3.
>
> Documentation/devicetree/bindings/net/cpsw.txt | 4 ++--
For the binding:
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2015-12-29 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 0:36 [PATCH 0/3] drivers: net: cpsw: phy-handle fixes David Rivshin (Allworx)
2015-12-23 0:36 ` [PATCH 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config David Rivshin (Allworx)
2015-12-23 0:36 ` [PATCH 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property David Rivshin (Allworx)
2015-12-29 20:30 ` Rob Herring [this message]
2015-12-23 0:36 ` [PATCH 3/3] drivers: net: cpsw: use of_phy_connect() in fixed-link case David Rivshin (Allworx)
2015-12-23 17:04 ` [PATCH 0/3] drivers: net: cpsw: phy-handle fixes David Miller
2015-12-23 18:35 ` Markus Brunner
2015-12-23 21:51 ` David Rivshin (Allworx)
[not found] ` <CABr+WT=oDpp56jouAD57UM8_38geD1MMizZcDnx14maf2ohpCw@mail.gmail.com>
2015-12-23 21:54 ` David Rivshin (Allworx)
[not found] ` <CABr+WTm=Oo16=qB6dyO6ZhUUz0307ROi=o270Rac2R4W5-usjg@mail.gmail.com>
2015-12-24 1:18 ` David Rivshin (Allworx)
2015-12-24 9:10 ` Markus Brunner
2016-02-13 1:28 ` David Rivshin (Allworx)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151229203034.GA18528@rob-hp-laptop \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=drivshin.allworx@gmail.com \
--cc=dtrautmann@ibhsoftec-sps.de \
--cc=hs@denx.de \
--cc=kernel@iktek.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=systemprogrammierung.brunner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox