From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH] ARM64: tegra: Add support for Google Pixel C Date: Wed, 6 Jan 2016 09:46:16 +0000 Message-ID: <20160106094616.GA563@leverpostej> References: <1452073222-2956-1-git-send-email-jonathanh@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1452073222-2956-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jon Hunter Cc: Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Stephen Warren , Thierry Reding , Alexandre Courbot , Olof Johansson , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Wed, Jan 06, 2016 at 09:40:22AM +0000, Jon Hunter wrote: > Add initial device-tree support for Google Pixel C (a.k.a. Smaug) based > upon Tegra210 SoC with 3 GiB of LPDDR4 RAM. > > Signed-off-by: Jon Hunter > --- > arch/arm64/boot/dts/nvidia/Makefile | 1 + > arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 42 +++++++++++++++++++++++++++ > 2 files changed, 43 insertions(+) > create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts > > diff --git a/arch/arm64/boot/dts/nvidia/Makefile b/arch/arm64/boot/dts/nvidia/Makefile > index a7e865da1005..0f7cdf3e05c1 100644 > --- a/arch/arm64/boot/dts/nvidia/Makefile > +++ b/arch/arm64/boot/dts/nvidia/Makefile > @@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb > dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb > dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb > dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb > +dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb > > always := $(dtb-y) > clean-files := *.dtb > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts > new file mode 100644 > index 000000000000..a7474f5fcbcc > --- /dev/null > +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts > @@ -0,0 +1,42 @@ > +/dts-v1/; > + > +#include "tegra210.dtsi" > + > +/ { > + model = "Google Pixel C"; > + compatible = "google,smaug-rev8", "google,smaug-rev7", > + "google,smaug-rev6", "google,smaug-rev5", > + "google,smaug-rev4", "google,smaug-rev3", > + "google,smaug-rev1", "google,smaug", "nvidia,tegra210"; This looks a little funky. Is each revision a strict superset of the previous version? > + > + chosen { > + bootargs = "console=ttyS0,115200n8 earlycon=uart8250,mmio32,0x70006000"; > + }; Use stdout-path. Otherwise this looks ok. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html