Re: [PATCH 2/2] drm: bridge: add sil902x DT bindings doc

Rob Herring
2016-01-06T13:19:59Z

On Wed, Jan 06, 2016 at 12:25:51PM +0100, Boris Brezillon wrote:
> Add Sil9022 DT bindings description.
>
> Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> .../devicetree/bindings/display/bridge/sil902x.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/sil902x.txt
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil902x.txt b/Documentation/devicetree/bindings/display/bridge/sil902x.txt
> new file mode 100644
> index 0000000..7f1339f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/sil902x.txt
> @@ -0,0 +1,31 @@
> +sil902x HDMI bridge bindings
> +
> +Required properties:
> + - compatible: "sil,sil9022"
> + - reg: i2c address of the bridge
> + - reset-gpios: OF device-tree gpio specification for RST_N pin.
> +
> +Optional properties:
> + - interrupts-extended or interrupt-parent + interrupts: describe
> + the interrupt line used to inform the host about hotplug events.
> +
> +Optional subnodes:
> + - video input: Device node can contain video input port node to
> + connect the bridge to a display controller output (See this
> + documentation [1]).
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> + hdmi-bridge@39 {
> + compatible = "sil,sil9022";
> + reg = <0x39>;
> + reset-gpios = <&gpx1 5 1 0 0>;

4 GPIO cells? Valid, but unusual.

> + ports {
> + port@0 {

Either need a reg property here or drop the unit address. You could
remove ports as well.

> + bridge_in: endpoint {
> + remote-endpoint = <&dc_out>;
> + };
> + };
> + };
> + };
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html