From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Date: Wed, 6 Jan 2016 15:05:31 +0100 Message-ID: <20160106140531.GK11722@lukather> References: <1452085914-29340-1-git-send-email-vishnupatekar0510@gmail.com> <1452085914-29340-3-git-send-email-vishnupatekar0510@gmail.com> <20160106132505.GJ563@leverpostej> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Xb8pJpF45Qg/t7GZ" Return-path: Content-Disposition: inline In-Reply-To: <20160106132505.GJ563@leverpostej> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Mark Rutland Cc: Vishnu Patekar , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --Xb8pJpF45Qg/t7GZ Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Mark, On Wed, Jan 06, 2016 at 01:25:05PM +0000, Mark Rutland wrote: > > + clocks { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + osc24M: osc24M_clk { > > + #clock-cells = <0>; > > + compatible = "fixed-clock"; > > + clock-frequency = <24000000>; > > + clock-output-names = "osc24M"; > > + }; > > + > > + osc32k: osc32k_clk { > > + #clock-cells = <0>; > > + compatible = "fixed-clock"; > > + clock-frequency = <32768>; > > + clock-output-names = "osc32k"; > > + }; > > + }; > > Just put the clocks under the root node. 'clocks' is not a special > node. No, it's not a special node, but it's a very convenient one. It avoids "crippling" the main SoC definition with all the clocks definition, and keep the noise relatively low. And a bunch of other maintainers seem to agree: $ git grep "clocks {" -- arch/arm/boot/dts/ arch/arm64/boot/dts/ | wc -l 271 Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --Xb8pJpF45Qg/t7GZ--