From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Kumar Gala <galak@codeaurora.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH 2/2] drm: bridge: add sil902x DT bindings doc
Date: Wed, 6 Jan 2016 14:24:57 +0100 [thread overview]
Message-ID: <20160106142457.28c8af15@bbrezillon> (raw)
In-Reply-To: <20160106131959.GA18121@rob-hp-laptop>
Hi Rob,
On Wed, 6 Jan 2016 07:19:59 -0600
Rob Herring <robh@kernel.org> wrote:
> On Wed, Jan 06, 2016 at 12:25:51PM +0100, Boris Brezillon wrote:
> > Add Sil9022 DT bindings description.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > ---
> > .../devicetree/bindings/display/bridge/sil902x.txt | 31 ++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/bridge/sil902x.txt
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/sil902x.txt b/Documentation/devicetree/bindings/display/bridge/sil902x.txt
> > new file mode 100644
> > index 0000000..7f1339f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/sil902x.txt
> > @@ -0,0 +1,31 @@
> > +sil902x HDMI bridge bindings
> > +
> > +Required properties:
> > + - compatible: "sil,sil9022"
> > + - reg: i2c address of the bridge
> > + - reset-gpios: OF device-tree gpio specification for RST_N pin.
> > +
> > +Optional properties:
> > + - interrupts-extended or interrupt-parent + interrupts: describe
> > + the interrupt line used to inform the host about hotplug events.
> > +
> > +Optional subnodes:
> > + - video input: Device node can contain video input port node to
> > + connect the bridge to a display controller output (See this
> > + documentation [1]).
> > +
> > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> > +
> > +Example:
> > + hdmi-bridge@39 {
> > + compatible = "sil,sil9022";
> > + reg = <0x39>;
> > + reset-gpios = <&gpx1 5 1 0 0>;
>
> 4 GPIO cells? Valid, but unusual.
Hehe, I blindly copied nxp,ptn3460 doc, which is defining such GPIO
descriptors :-). I can change that if you want.
>
> > + ports {
> > + port@0 {
>
> Either need a reg property here or drop the unit address. You could
> remove ports as well.
Actually we'll likely define a 2nd port for the audio input, so I'd
prefer keeping the ports and @0 suffix and adding a reg property rather
than just defining port { ... };
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-06 13:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 11:25 [PATCH 1/2] drm: bridge: sil902x Boris Brezillon
2016-01-06 11:25 ` [PATCH 2/2] drm: bridge: add sil902x DT bindings doc Boris Brezillon
[not found] ` <1452079551-30914-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-01-06 13:19 ` Rob Herring
2016-01-06 13:24 ` Boris Brezillon [this message]
2016-01-06 12:13 ` [PATCH 1/2] drm: bridge: sil902x kbuild test robot
2016-01-06 12:25 ` [PATCH v2 " Boris Brezillon
2016-01-07 5:42 ` Archit Taneja
2016-01-07 9:35 ` Boris Brezillon
[not found] ` <1452083126-18211-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-03-16 13:14 ` Nicolas Ferre
2016-01-06 12:36 ` [PATCH " kbuild test robot
2016-01-06 13:47 ` Sascha Hauer
2016-01-06 13:53 ` Boris Brezillon
2016-01-06 15:26 ` Sascha Hauer
[not found] ` <20160106152638.GS13058-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-01-06 15:35 ` Ilia Mirkin
[not found] ` <CAKb7UvghNhGZLUX_3LchZoiYAtywN99tEpDy+k8ApPnPF-ce+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-07 7:01 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106142457.28c8af15@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).