[PATCH] ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

[PATCH] ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

[Aleksei Mamlin]

Marsboard A10 have four red LEDs, the first one can be used for heartbeat indication.

Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 arch/arm/boot/dts/sun4i-a10-marsboard.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/sun4i-a10-marsboard.dts b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
index 8e50723..ff73ee1 100644
--- a/arch/arm/boot/dts/sun4i-a10-marsboard.dts
+++ b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
@@ -68,6 +68,7 @@
 		red1 {
 			label = "marsboard:red1:usr";
 			gpios = <&pio 1 5 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
 		};
 
 		red2 {
-- 
2.4.10

Re: [PATCH] ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On Sat, Dec 26, 2015 at 12:57:59PM +0300, Aleksei Mamlin wrote:
> Marsboard A10 have four red LEDs, the first one can be used for
> heartbeat indication.
> 
> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

I'm really not sure about this one.

This is something that can easily be changed through sysfs, and it
will likely end up being a "war" on what trigger people want to use.

Hans, Chen-Yu, What's your view on this?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Re: Re: [PATCH] ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

[Hans de Goede]

Hi,

On 27-12-15 21:51, Maxime Ripard wrote:
> On Sat, Dec 26, 2015 at 12:57:59PM +0300, Aleksei Mamlin wrote:
>> Marsboard A10 have four red LEDs, the first one can be used for
>> heartbeat indication.
>>
>> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> I'm really not sure about this one.
>
> This is something that can easily be changed through sysfs, and it
> will likely end up being a "war" on what trigger people want to use.
>
> Hans, Chen-Yu, What's your view on this?

I would prefer to not set any (default) led triggers in the dts
files for sunxi boards.

Regards,

Hans

Re: Re: [PATCH] ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

[Chen-Yu Tsai]

On Tue, Dec 29, 2015 at 8:33 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Hi,
>
> On 27-12-15 21:51, Maxime Ripard wrote:
>>
>> On Sat, Dec 26, 2015 at 12:57:59PM +0300, Aleksei Mamlin wrote:
>>>
>>> Marsboard A10 have four red LEDs, the first one can be used for
>>> heartbeat indication.
>>>
>>> Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>>
>> I'm really not sure about this one.
>>
>> This is something that can easily be changed through sysfs, and it
>> will likely end up being a "war" on what trigger people want to use.
>>
>> Hans, Chen-Yu, What's your view on this?
>
>
> I would prefer to not set any (default) led triggers in the dts
> files for sunxi boards.

+1

ChenYu

Re: [PATCH] ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

[Aleksei Mamlin]

On Sun, 27 Dec 2015 21:51:51 +0100
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:

> On Sat, Dec 26, 2015 at 12:57:59PM +0300, Aleksei Mamlin wrote:
> > Marsboard A10 have four red LEDs, the first one can be used for
> > heartbeat indication.
> > 
> > Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> I'm really not sure about this one.
> 
> This is something that can easily be changed through sysfs, and it
> will likely end up being a "war" on what trigger people want to use.
> 

If so, then Ok, please ignore this patch.

Is there any way to set led triggers through cmdline instead of sysfs?

>
> Hans, Chen-Yu, What's your view on this?
> 
> Thanks,
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

Re: [PATCH] ARM: dts: sun4i: Use red1 LED for heartbeat indication on Marsboard A10

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

On Tue, Dec 29, 2015 at 04:58:19PM +0300, Aleksei Mamlin wrote:
> On Sun, 27 Dec 2015 21:51:51 +0100
> Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> 
> > On Sat, Dec 26, 2015 at 12:57:59PM +0300, Aleksei Mamlin wrote:
> > > Marsboard A10 have four red LEDs, the first one can be used for
> > > heartbeat indication.
> > > 
> > > Signed-off-by: Aleksei Mamlin <mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > 
> > I'm really not sure about this one.
> > 
> > This is something that can easily be changed through sysfs, and it
> > will likely end up being a "war" on what trigger people want to use.
> > 
> 
> If so, then Ok, please ignore this patch.
> 
> Is there any way to set led triggers through cmdline instead of sysfs?

Unfortunately, I don't think there's any.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com