Re: [rtc-linux] [PATCH 5/6] rtc: max77620: add support for max77620/max20024 RTC driver

Laxman Dewangan
2016-01-08T13:04:29Z

On Friday 08 January 2016 06:21 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Fri, Jan 08, 2016 at 03:50:46PM +0530, Laxman Dewangan wrote:
>
>> Yaah, that is the issue on IP based PMIC system and it happen with the Maxim
>> and TI.
>> The MFD and its sub module drivers are too much couped and hence dificult
>> to use the IP driver across PMIC. For almost all Maxim PMIC, we end up of
>> same type of RTC driver.
>> Probably, we need to enhance the mfd sub system to allow sub module driver
>> to decoupe from its APIs.
> Could you be more specific about the issues here please? I can't think
> of any barriers and you've not mentioned any barriers...
>

I took MAX77686 and MAX77620. They are almost same IP on both PMIC and I
think it can be used if we decouple it. Typical codes are same as
follows: (I posted here for quick reference, excuse me if it is long).

If we get the parent device, regmap handle and interrupt number from mfd
core independent of the PMIC (MAX77620 or MAX77686), then same driver
can be used here.
Two way which I can think of here:

1: We need to make independent maxim RTC IP driver which may be platform
driver and get above information from the platform data.

This way both mfd driver can pass the platform data with required
information and decoupled.

2. Other way is that rtc driver will register as independent platform
driver and pass the mfd dt handle to this driver. Later maxim rtc driver
can query for getting the regmap, interrupt number etc.

Any other approach are welcome.

sample code:
************************8
Typical function from max77686:

static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)
{
struct max77686_rtc_info *info = dev_get_drvdata(dev);
u8 data[RTC_NR_TIME];
int ret;

ret = max77686_rtc_tm_to_data(tm, data);
if (ret < 0)
return ret;

mutex_lock(&info->lock);

ret = regmap_bulk_write(info->max77686->rtc_regmap,
MAX77686_RTC_SEC, data, RTC_NR_TIME);
if (ret < 0) {
dev_err(info->dev, "%s: fail to write time reg(%d)\n",
__func__,
ret);
goto out;
}

ret = max77686_rtc_update(info, MAX77686_RTC_WRITE);

out:
mutex_unlock(&info->lock);
return ret;
}

static int max77620_rtc_set_time(struct device *dev, struct rtc_time *tm)
{
struct max77620_rtc *rtc = dev_get_drvdata(dev);
struct device *parent = max77620_to_parent(rtc);
u8 buf[RTC_NR];
int ret;

ret = max77620_rtc_tm_to_reg(rtc, buf, tm, 0);
if (ret < 0)
return ret;

mutex_lock(&rtc->io_lock);

ret = max77620_reg_writes(parent, MAX77620_RTC_SLAVE, addr,
len, vals);
if (ret < 0) {
dev_err(rtc->dev, "Reg 0x%02x write failed: %d\n",
addr, ret);
goto out;
}

ret = max77620_rtc_update_buffer(rtc, 1);

out:
mutex_unlock(&rtc->io_lock);

return ret;
}