From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2 Date: Sun, 10 Jan 2016 20:01:58 +0100 Message-ID: <20160110190158.GK24441@pengutronix.de> References: <1452429613-28783-1-git-send-email-mans@mansr.com> <1473600647.505612.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de> <89586980.506110.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange@email.1und1.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <89586980.506110.cb24b396-67be-4b7b-9938-7cb30ef4fe05.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Wahren Cc: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Sascha Hauer , Kumar Gala , Shawn Guo , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hello, On Sun, Jan 10, 2016 at 02:38:00PM +0100, Stefan Wahren wrote: > > M=E5ns Rullg=E5rd hat am 10. Januar 2016 um 14:13 = geschrieben: > > Stefan Wahren writes: > > > > > Hi Mans, > > > > > >> Mans Rullgard hat am 10. Januar 2016 um 13:40 g= eschrieben: > > >> > > >> > > >> Add pinmux setting for USB1 overcurrent on pwm2 pad. > > > > > > could you please change your patch to describe why you need to ad= d > > > this pinmux? > > > > I'm working on a board that is wired that way. I can of course put = this > > in the board-specific dts if that's preferable. >=20 > So the board isn't submitted to mainline? >=20 > IMHO the change is okay, but the description doesn't explain why is i= t needed. >=20 > So a suitable description would be that it's needed for board xy. The problem with pinmuxing on i.MX23/28 is that the order of pinmux groups is to a certain degree important. So not everything is possible in the machine specific dts. (I didn't have an eye on this issue, maybe it's fixed in the meantime?) Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= | -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html