From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Date: Mon, 11 Jan 2016 05:48:46 +0000 Message-ID: <20160111054846.GD3331@x1> References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Jiancheng Xue Cc: mturquette@baylibre.com, sboyd@codeaurora.org, p.zabel@pengutronix.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, khilman@linaro.org, arnd@arndb.de, olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, bintian.wang@huawei.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yanhaifeng@hisilicon.com, yanghongwei@hisilicon.com, suwenping@hisilicon.com, ml.yang@hisilicon.com, gaofei@hisilicon.com, zhangzhenxing@hisilicon.com, xuejiancheng@hisilicon.com List-Id: devicetree@vger.kernel.org On Fri, 08 Jan 2016, Jiancheng Xue wrote: > Add device tree bindings for Hi3519 system controller. >=20 > Signed-off-by: Jiancheng Xue > --- > Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt I have this patch, but none of the others in the set, thus I am lacking context. > diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Docum= entation/devicetree/bindings/mfd/hi3519.txt > new file mode 100644 > index 0000000..115c5be > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt > @@ -0,0 +1,14 @@ > +* Hisilicon Hi3519 System Controller Block > + > +This bindings use the following binding: > +Documentation/devicetree/bindings/mfd/syscon.txt > + > +Required properties: > +- compatible: "hisilicon,hi3519-sysctrl". > +- reg: the register region of this block > + > +Examples: > +sysctrl: system-controller@12010000 { > + compatible =3D "hisilicon,hi3519-sysctrl", "syscon"; > + reg =3D <0x12010000 0x1000>; > +}; There is no requirement (nor want) for binding documents where the given device is simply using highly generic bindings. This just amounts to churn. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog