[PATCH 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

[PATCH 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

[Wenyou Yang]

This patch set adds support for the Active-semi ACT8945A PMIC.
It is a Multi Function Device with the following subdevices:
 - Regulator
 - Charger

It is interfaced to the host controller using I2C interface,
ACT8945A is a child device of the I2C.


Wenyou Yang (2):
  mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver
  mfd: add documentation for ACT8945A DT bindings

 Documentation/devicetree/bindings/mfd/act8945a.txt |   16 +++
 drivers/mfd/Kconfig                                |    8 ++
 drivers/mfd/Makefile                               |    1 +
 drivers/mfd/act8945a.c                             |  122 ++++++++++++++++++++
 include/linux/mfd/act8945a.h                       |   25 ++++
 5 files changed, 172 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
 create mode 100644 drivers/mfd/act8945a.c
 create mode 100644 include/linux/mfd/act8945a.h

-- 
1.7.9.5

[PATCH 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

[Wenyou Yang]

This patch adds support for the Active-semi ACT8945A PMIC.
It is a Multi Function Device with the following subdevices:
 - Regulator
 - Charger

It is interfaced to the host controller using I2C interface,
ACT8945A is a child device of the I2C.

Signed-off-by: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
---

 drivers/mfd/Kconfig          |    8 +++
 drivers/mfd/Makefile         |    1 +
 drivers/mfd/act8945a.c       |  122 ++++++++++++++++++++++++++++++++++++++++++
 include/linux/mfd/act8945a.h |   25 +++++++++
 4 files changed, 156 insertions(+)
 create mode 100644 drivers/mfd/act8945a.c
 create mode 100644 include/linux/mfd/act8945a.h

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 9581ebb..018c72d 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -18,6 +18,14 @@ config MFD_CS5535
 	  This is the core driver for CS5535/CS5536 MFD functions.  This is
           necessary for using the board's GPIO and MFGPT functionality.
 
+config MFD_ACT8945A
+	bool "Active-semi ACT8945A"
+	select MFD_CORE
+	select REGMAP_I2C
+	depends on I2C && OF
+	help
+	  Support for the ACT8945A PMIC from Active-Semi
+
 config MFD_AS3711
 	bool "AMS AS3711"
 	select MFD_CORE
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 0f230a6..2f1ca82 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -6,6 +6,7 @@
 obj-$(CONFIG_MFD_88PM860X)	+= 88pm860x.o
 obj-$(CONFIG_MFD_88PM800)	+= 88pm800.o 88pm80x.o
 obj-$(CONFIG_MFD_88PM805)	+= 88pm805.o 88pm80x.o
+obj-$(CONFIG_MFD_ACT8945A)	+= act8945a.o
 obj-$(CONFIG_MFD_SM501)		+= sm501.o
 obj-$(CONFIG_MFD_ASIC3)		+= asic3.o tmio_core.o
 obj-$(CONFIG_MFD_BCM590XX)	+= bcm590xx.o
diff --git a/drivers/mfd/act8945a.c b/drivers/mfd/act8945a.c
new file mode 100644
index 0000000..b9b8685
--- /dev/null
+++ b/drivers/mfd/act8945a.c
@@ -0,0 +1,122 @@
+/*
+ * MFD driver for Active-semi ACT8945a PMIC
+ *
+ * Copyright (C) 2015 Atmel Corporation.
+ *                    Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/i2c.h>
+#include <linux/mfd/act8945a.h>
+#include <linux/mfd/core.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
+#include <linux/regmap.h>
+
+static const struct mfd_cell act8945a_devs[] = {
+	{
+		.name = "act8945a-pmic",
+		.of_compatible = "active-semi,act8945a-regulator",
+	},
+	{
+		.name = "act8945a-charger",
+		.of_compatible = "active-semi,act8945a-charger",
+	},
+};
+
+static const struct regmap_config act8945a_regmap_config = {
+	.reg_bits = 8,
+	.val_bits = 8,
+};
+
+static int act8945a_i2c_probe(struct i2c_client *client,
+			     const struct i2c_device_id *id)
+{
+	struct act8945a_dev *act8945a;
+	int ret;
+
+	act8945a = devm_kzalloc(&client->dev, sizeof(*act8945a), GFP_KERNEL);
+	if (act8945a == NULL)
+		return -ENOMEM;
+
+	i2c_set_clientdata(client, act8945a);
+
+	act8945a->dev = &client->dev;
+	act8945a->i2c_client = client;
+	act8945a->regmap = devm_regmap_init_i2c(client,
+						&act8945a_regmap_config);
+	if (IS_ERR(act8945a->regmap)) {
+		ret = PTR_ERR(act8945a->regmap);
+		dev_err(&client->dev, "regmap init failed: %d\n", ret);
+		return ret;
+	}
+
+	ret = mfd_add_devices(act8945a->dev, -1, act8945a_devs,
+			      ARRAY_SIZE(act8945a_devs), NULL, 0, NULL);
+	if (ret < 0) {
+		dev_err(&client->dev, "mfd_add_devices failed: %d\n", ret);
+		return ret;
+	}
+
+	dev_info(&client->dev, "added %zu mfd sub-devices\n",
+		 ARRAY_SIZE(act8945a_devs));
+
+	return 0;
+
+}
+
+static int act8945a_i2c_remove(struct i2c_client *i2c)
+{
+	struct act8945a_dev *act8945a = i2c_get_clientdata(i2c);
+
+	mfd_remove_devices(act8945a->dev);
+
+	return 0;
+}
+
+static const struct i2c_device_id act8945a_i2c_id[] = {
+	{ "act8945a", 0 },
+	{}
+};
+MODULE_DEVICE_TABLE(i2c, act8945a_i2c_id);
+
+static const struct of_device_id act8945a_of_match[] = {
+	{.compatible = "active-semi,act8945a", },
+	{},
+};
+MODULE_DEVICE_TABLE(of, act8945a_of_match);
+
+static struct i2c_driver act8945a_i2c_driver = {
+	.driver = {
+		   .name = "act8945a",
+		   .owner = THIS_MODULE,
+		   .of_match_table = of_match_ptr(act8945a_of_match),
+	},
+	.probe = act8945a_i2c_probe,
+	.remove = act8945a_i2c_remove,
+	.id_table = act8945a_i2c_id,
+};
+
+static int __init act8945a_i2c_init(void)
+{
+	return i2c_add_driver(&act8945a_i2c_driver);
+}
+subsys_initcall(act8945a_i2c_init);
+
+static void __exit act8945a_i2c_exit(void)
+{
+	i2c_del_driver(&act8945a_i2c_driver);
+}
+module_exit(act8945a_i2c_exit);
+
+MODULE_DESCRIPTION("ACT8945A PMIC multi-function driver");
+MODULE_LICENSE("GPL v2");
+MODULE_AUTHOR("Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>");
diff --git a/include/linux/mfd/act8945a.h b/include/linux/mfd/act8945a.h
new file mode 100644
index 0000000..5b18d16
--- /dev/null
+++ b/include/linux/mfd/act8945a.h
@@ -0,0 +1,25 @@
+/*
+ * MFD for Active-semi ACT8945A PMIC
+ *
+ * Copyright (C) 2015 Atmel Corporation.
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef _LINUX_MFD_ACT8945A_H
+#define _LINUX_MFD_ACT8945A_H
+
+struct act8945a_dev {
+	struct device *dev;
+	struct i2c_client *i2c_client;
+	struct regmap *regmap;
+};
+
+#endif
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

[Lee Jones]

On Fri, 08 Jan 2016, Wenyou Yang wrote:

> This patch adds support for the Active-semi ACT8945A PMIC.
> It is a Multi Function Device with the following subdevices:
>  - Regulator
>  - Charger
> 
> It is interfaced to the host controller using I2C interface,
> ACT8945A is a child device of the I2C.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> 
>  drivers/mfd/Kconfig          |    8 +++
>  drivers/mfd/Makefile         |    1 +
>  drivers/mfd/act8945a.c       |  122 ++++++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/act8945a.h |   25 +++++++++
>  4 files changed, 156 insertions(+)
>  create mode 100644 drivers/mfd/act8945a.c
>  create mode 100644 include/linux/mfd/act8945a.h
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 9581ebb..018c72d 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -18,6 +18,14 @@ config MFD_CS5535
>  	  This is the core driver for CS5535/CS5536 MFD functions.  This is
>            necessary for using the board's GPIO and MFGPT functionality.
>  
> +config MFD_ACT8945A
> +	bool "Active-semi ACT8945A"
> +	select MFD_CORE
> +	select REGMAP_I2C
> +	depends on I2C && OF
> +	help
> +	  Support for the ACT8945A PMIC from Active-Semi

Checkpatch usually complains about single line helps.

>  config MFD_AS3711
>  	bool "AMS AS3711"
>  	select MFD_CORE
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 0f230a6..2f1ca82 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -6,6 +6,7 @@
>  obj-$(CONFIG_MFD_88PM860X)	+= 88pm860x.o
>  obj-$(CONFIG_MFD_88PM800)	+= 88pm800.o 88pm80x.o
>  obj-$(CONFIG_MFD_88PM805)	+= 88pm805.o 88pm80x.o
> +obj-$(CONFIG_MFD_ACT8945A)	+= act8945a.o
>  obj-$(CONFIG_MFD_SM501)		+= sm501.o
>  obj-$(CONFIG_MFD_ASIC3)		+= asic3.o tmio_core.o
>  obj-$(CONFIG_MFD_BCM590XX)	+= bcm590xx.o
> diff --git a/drivers/mfd/act8945a.c b/drivers/mfd/act8945a.c
> new file mode 100644
> index 0000000..b9b8685
> --- /dev/null
> +++ b/drivers/mfd/act8945a.c
> @@ -0,0 +1,122 @@
> +/*
> + * MFD driver for Active-semi ACT8945a PMIC
> + *
> + * Copyright (C) 2015 Atmel Corporation.

Please update this.

> + *                    Wenyou Yang <wenyou.yang@atmel.com>

* Author: Wenyou Yang <wenyou.yang@atmel.com>

> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

This is the long version.  Any chance it can be shortened?

> + */
> +
> +#include <linux/i2c.h>
> +#include <linux/mfd/act8945a.h>
> +#include <linux/mfd/core.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/regmap.h>
> +
> +static const struct mfd_cell act8945a_devs[] = {
> +	{
> +		.name = "act8945a-pmic",
> +		.of_compatible = "active-semi,act8945a-regulator",
> +	},
> +	{
> +		.name = "act8945a-charger",
> +		.of_compatible = "active-semi,act8945a-charger",
> +	},
> +};
> +
> +static const struct regmap_config act8945a_regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +};
> +
> +static int act8945a_i2c_probe(struct i2c_client *client,
> +			     const struct i2c_device_id *id)
> +{
> +	struct act8945a_dev *act8945a;
> +	int ret;
> +
> +	act8945a = devm_kzalloc(&client->dev, sizeof(*act8945a), GFP_KERNEL);
> +	if (act8945a == NULL)

if (!act8945a)

> +		return -ENOMEM;
> +
> +	i2c_set_clientdata(client, act8945a);
> +
> +	act8945a->dev = &client->dev;
> +	act8945a->i2c_client = client;

If you're saving 'client' already, you don't need to save 'dev' too,
as one can be retrieved from the other.

> +	act8945a->regmap = devm_regmap_init_i2c(client,
> +						&act8945a_regmap_config);

Don't we have a generic call to obtain a single 8bit register yet?

> +	if (IS_ERR(act8945a->regmap)) {
> +		ret = PTR_ERR(act8945a->regmap);
> +		dev_err(&client->dev, "regmap init failed: %d\n", ret);
> +		return ret;
> +	}
> +
> +	ret = mfd_add_devices(act8945a->dev, -1, act8945a_devs,

Please use the correct defines, instead of '-1'.

> +			      ARRAY_SIZE(act8945a_devs), NULL, 0, NULL);
> +	if (ret < 0) {

if (ret)

> +		dev_err(&client->dev, "mfd_add_devices failed: %d\n", ret);

Be more explicit.

"Failed to add sub devices".

> +		return ret;
> +	}
> +
> +	dev_info(&client->dev, "added %zu mfd sub-devices\n",
> +		 ARRAY_SIZE(act8945a_devs));

This serves no one, please remove.

> +	return 0;
> +
> +}
> +
> +static int act8945a_i2c_remove(struct i2c_client *i2c)
> +{
> +	struct act8945a_dev *act8945a = i2c_get_clientdata(i2c);
> +
> +	mfd_remove_devices(act8945a->dev);

mfd_remove_devices(i2c->dev);

> +	return 0;
> +}
> +
> +static const struct i2c_device_id act8945a_i2c_id[] = {
> +	{ "act8945a", 0 },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(i2c, act8945a_i2c_id);
> +
> +static const struct of_device_id act8945a_of_match[] = {
> +	{.compatible = "active-semi,act8945a", },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, act8945a_of_match);
> +
> +static struct i2c_driver act8945a_i2c_driver = {
> +	.driver = {
> +		   .name = "act8945a",
> +		   .owner = THIS_MODULE,

Remove this line, it's taken care of elsewhere.

> +		   .of_match_table = of_match_ptr(act8945a_of_match),
> +	},
> +	.probe = act8945a_i2c_probe,
> +	.remove = act8945a_i2c_remove,
> +	.id_table = act8945a_i2c_id,
> +};
> +
> +static int __init act8945a_i2c_init(void)
> +{
> +	return i2c_add_driver(&act8945a_i2c_driver);
> +}
> +subsys_initcall(act8945a_i2c_init);
> +
> +static void __exit act8945a_i2c_exit(void)
> +{
> +	i2c_del_driver(&act8945a_i2c_driver);
> +}
> +module_exit(act8945a_i2c_exit);
> +
> +MODULE_DESCRIPTION("ACT8945A PMIC multi-function driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_AUTHOR("Wenyou Yang <wenyou.yang@atmel.com>");
> diff --git a/include/linux/mfd/act8945a.h b/include/linux/mfd/act8945a.h
> new file mode 100644
> index 0000000..5b18d16
> --- /dev/null
> +++ b/include/linux/mfd/act8945a.h
> @@ -0,0 +1,25 @@
> +/*
> + * MFD for Active-semi ACT8945A PMIC
> + *
> + * Copyright (C) 2015 Atmel Corporation.

Please update this.

> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#ifndef _LINUX_MFD_ACT8945A_H
> +#define _LINUX_MFD_ACT8945A_H
> +
> +struct act8945a_dev {
> +	struct device *dev;

I don't think you need this.

> +	struct i2c_client *i2c_client;

Where is this used?

> +	struct regmap *regmap;

Where is this used?

> +};
> +
> +#endif

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [PATCH 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

[Yang, Wenyou]

Hi Lee,

Thank you very much for so many comments.

> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@linaro.org]
> Sent: 2016年1月11日 13:49
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>;
> Mark Rutland <mark.rutland@arm.com>; Ian Campbell
> <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Ferre,
> Nicolas <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD
> driver
> 
> On Fri, 08 Jan 2016, Wenyou Yang wrote:
> 
> > This patch adds support for the Active-semi ACT8945A PMIC.
> > It is a Multi Function Device with the following subdevices:
> >  - Regulator
> >  - Charger
> >
> > It is interfaced to the host controller using I2C interface, ACT8945A
> > is a child device of the I2C.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> >  drivers/mfd/Kconfig          |    8 +++
> >  drivers/mfd/Makefile         |    1 +
> >  drivers/mfd/act8945a.c       |  122
> ++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/act8945a.h |   25 +++++++++
> >  4 files changed, 156 insertions(+)
> >  create mode 100644 drivers/mfd/act8945a.c  create mode 100644
> > include/linux/mfd/act8945a.h
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index
> > 9581ebb..018c72d 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -18,6 +18,14 @@ config MFD_CS5535
> >  	  This is the core driver for CS5535/CS5536 MFD functions.  This is
> >            necessary for using the board's GPIO and MFGPT functionality.
> >
> > +config MFD_ACT8945A
> > +	bool "Active-semi ACT8945A"
> > +	select MFD_CORE
> > +	select REGMAP_I2C
> > +	depends on I2C && OF
> > +	help
> > +	  Support for the ACT8945A PMIC from Active-Semi
> 
> Checkpatch usually complains about single line helps.
> 
> >  config MFD_AS3711
> >  	bool "AMS AS3711"
> >  	select MFD_CORE
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index
> > 0f230a6..2f1ca82 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -6,6 +6,7 @@
> >  obj-$(CONFIG_MFD_88PM860X)	+= 88pm860x.o
> >  obj-$(CONFIG_MFD_88PM800)	+= 88pm800.o 88pm80x.o
> >  obj-$(CONFIG_MFD_88PM805)	+= 88pm805.o 88pm80x.o
> > +obj-$(CONFIG_MFD_ACT8945A)	+= act8945a.o
> >  obj-$(CONFIG_MFD_SM501)		+= sm501.o
> >  obj-$(CONFIG_MFD_ASIC3)		+= asic3.o tmio_core.o
> >  obj-$(CONFIG_MFD_BCM590XX)	+= bcm590xx.o
> > diff --git a/drivers/mfd/act8945a.c b/drivers/mfd/act8945a.c new file
> > mode 100644 index 0000000..b9b8685
> > --- /dev/null
> > +++ b/drivers/mfd/act8945a.c
> > @@ -0,0 +1,122 @@
> > +/*
> > + * MFD driver for Active-semi ACT8945a PMIC
> > + *
> > + * Copyright (C) 2015 Atmel Corporation.
> 
> Please update this.
> 
> > + *                    Wenyou Yang <wenyou.yang@atmel.com>
> 
> * Author: Wenyou Yang <wenyou.yang@atmel.com>
> 
> > + * This software is licensed under the terms of the GNU General
> > + Public
> > + * License version 2, as published by the Free Software Foundation,
> > + and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
> the
> > + * GNU General Public License for more details.
> 
> This is the long version.  Any chance it can be shortened?
> 
> > + */
> > +
> > +#include <linux/i2c.h>
> > +#include <linux/mfd/act8945a.h>
> > +#include <linux/mfd/core.h>
> > +#include <linux/module.h>
> > +#include <linux/of_device.h>
> > +#include <linux/regmap.h>
> > +
> > +static const struct mfd_cell act8945a_devs[] = {
> > +	{
> > +		.name = "act8945a-pmic",
> > +		.of_compatible = "active-semi,act8945a-regulator",
> > +	},
> > +	{
> > +		.name = "act8945a-charger",
> > +		.of_compatible = "active-semi,act8945a-charger",
> > +	},
> > +};
> > +
> > +static const struct regmap_config act8945a_regmap_config = {
> > +	.reg_bits = 8,
> > +	.val_bits = 8,
> > +};
> > +
> > +static int act8945a_i2c_probe(struct i2c_client *client,
> > +			     const struct i2c_device_id *id) {
> > +	struct act8945a_dev *act8945a;
> > +	int ret;
> > +
> > +	act8945a = devm_kzalloc(&client->dev, sizeof(*act8945a), GFP_KERNEL);
> > +	if (act8945a == NULL)
> 
> if (!act8945a)
> 
> > +		return -ENOMEM;
> > +
> > +	i2c_set_clientdata(client, act8945a);
> > +
> > +	act8945a->dev = &client->dev;
> > +	act8945a->i2c_client = client;
> 
> If you're saving 'client' already, you don't need to save 'dev' too, as one can be
> retrieved from the other.
> 
> > +	act8945a->regmap = devm_regmap_init_i2c(client,
> > +						&act8945a_regmap_config);
> 
> Don't we have a generic call to obtain a single 8bit register yet?

I didn't find the your said function. Could you point out? Thanks

> 
> > +	if (IS_ERR(act8945a->regmap)) {
> > +		ret = PTR_ERR(act8945a->regmap);
> > +		dev_err(&client->dev, "regmap init failed: %d\n", ret);
> > +		return ret;
> > +	}
> > +
> > +	ret = mfd_add_devices(act8945a->dev, -1, act8945a_devs,
> 
> Please use the correct defines, instead of '-1'.
> 
> > +			      ARRAY_SIZE(act8945a_devs), NULL, 0, NULL);
> > +	if (ret < 0) {
> 
> if (ret)
> 
> > +		dev_err(&client->dev, "mfd_add_devices failed: %d\n", ret);
> 
> Be more explicit.
> 
> "Failed to add sub devices".
> 
> > +		return ret;
> > +	}
> > +
> > +	dev_info(&client->dev, "added %zu mfd sub-devices\n",
> > +		 ARRAY_SIZE(act8945a_devs));
> 
> This serves no one, please remove.
> 
> > +	return 0;
> > +
> > +}
> > +
> > +static int act8945a_i2c_remove(struct i2c_client *i2c) {
> > +	struct act8945a_dev *act8945a = i2c_get_clientdata(i2c);
> > +
> > +	mfd_remove_devices(act8945a->dev);
> 
> mfd_remove_devices(i2c->dev);
> 
> > +	return 0;
> > +}
> > +
> > +static const struct i2c_device_id act8945a_i2c_id[] = {
> > +	{ "act8945a", 0 },
> > +	{}
> > +};
> > +MODULE_DEVICE_TABLE(i2c, act8945a_i2c_id);
> > +
> > +static const struct of_device_id act8945a_of_match[] = {
> > +	{.compatible = "active-semi,act8945a", },
> > +	{},
> > +};
> > +MODULE_DEVICE_TABLE(of, act8945a_of_match);
> > +
> > +static struct i2c_driver act8945a_i2c_driver = {
> > +	.driver = {
> > +		   .name = "act8945a",
> > +		   .owner = THIS_MODULE,
> 
> Remove this line, it's taken care of elsewhere.
> 
> > +		   .of_match_table = of_match_ptr(act8945a_of_match),
> > +	},
> > +	.probe = act8945a_i2c_probe,
> > +	.remove = act8945a_i2c_remove,
> > +	.id_table = act8945a_i2c_id,
> > +};
> > +
> > +static int __init act8945a_i2c_init(void) {
> > +	return i2c_add_driver(&act8945a_i2c_driver);
> > +}
> > +subsys_initcall(act8945a_i2c_init);
> > +
> > +static void __exit act8945a_i2c_exit(void) {
> > +	i2c_del_driver(&act8945a_i2c_driver);
> > +}
> > +module_exit(act8945a_i2c_exit);
> > +
> > +MODULE_DESCRIPTION("ACT8945A PMIC multi-function driver");
> > +MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Wenyou Yang
> > +<wenyou.yang@atmel.com>");
> > diff --git a/include/linux/mfd/act8945a.h
> > b/include/linux/mfd/act8945a.h new file mode 100644 index
> > 0000000..5b18d16
> > --- /dev/null
> > +++ b/include/linux/mfd/act8945a.h
> > @@ -0,0 +1,25 @@
> > +/*
> > + * MFD for Active-semi ACT8945A PMIC
> > + *
> > + * Copyright (C) 2015 Atmel Corporation.
> 
> Please update this.
> 
> > + * This software is licensed under the terms of the GNU General
> > + Public
> > + * License version 2, as published by the Free Software Foundation,
> > + and
> > + * may be copied, distributed, and modified under those terms.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
> the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#ifndef _LINUX_MFD_ACT8945A_H
> > +#define _LINUX_MFD_ACT8945A_H
> > +
> > +struct act8945a_dev {
> > +	struct device *dev;
> 
> I don't think you need this.

Yes, will be removed in the next version.

> 
> > +	struct i2c_client *i2c_client;
> 
> Where is this used?

Unused, will remove in the next version.

> 
> > +	struct regmap *regmap;
> 
> Where is this used?

To be used for sub devices to access the device register.

> 
> > +};
> > +
> > +#endif
> 
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source
> software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog


Best Regards,
Wenyou Yang

Re: [PATCH 1/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

[kbuild test robot]

Hi Wenyou,

[auto build test WARNING on v4.4-rc8]
[cannot apply to next-20160307]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Wenyou-Yang/mfd-act8945a-add-Active-semi-ACT8945A-PMIC-MFD-driver/20160108-100943


coccinelle warnings: (new ones prefixed by >>)

>> drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Wenyou Yang <wenyou.yang@atmel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 act8945a.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/mfd/act8945a.c
+++ b/drivers/mfd/act8945a.c
@@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(of, act8945a_of_matc
 static struct i2c_driver act8945a_i2c_driver = {
 	.driver = {
 		   .name = "act8945a",
-		   .owner = THIS_MODULE,
 		   .of_match_table = of_match_ptr(act8945a_of_match),
 	},
 	.probe = act8945a_i2c_probe,

RE: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

[Yang, Wenyou]

Hi Fengguang Wu,

Thank you for your patch.

> -----Original Message-----
> From: kbuild test robot [mailto:lkp@intel.com]
> Sent: 2016年3月8日 7:54
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: kbuild-all@01.org; Lee Jones <lee.jones@linaro.org>; Rob Herring
> <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Rutland
> <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar
> Gala <galak@codeaurora.org>; Ferre, Nicolas <Nicolas.FERRE@atmel.com>;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Yang, Wenyou
> <Wenyou.Yang@atmel.com>
> Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings
> 
> drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.
> 
>  Remove .owner field if calls are used which set it automatically
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> CC: Wenyou Yang <wenyou.yang@atmel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Reviewed-by: Wenyou Yang <wenyou.yang@atmel.com>

> ---
> 
>  act8945a.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/mfd/act8945a.c
> +++ b/drivers/mfd/act8945a.c
> @@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(of, act8945a_of_matc  static
> struct i2c_driver act8945a_i2c_driver = {
>  	.driver = {
>  		   .name = "act8945a",
> -		   .owner = THIS_MODULE,
>  		   .of_match_table = of_match_ptr(act8945a_of_match),
>  	},
>  	.probe = act8945a_i2c_probe,


Best Regards,
Wenyou Yang

Re: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings

[Lee Jones]

On Tue, 08 Mar 2016, Yang, Wenyou wrote:

> Hi Fengguang Wu,
> 
> Thank you for your patch.
> 
> > -----Original Message-----
> > From: kbuild test robot [mailto:lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org]
> > Sent: 2016年3月8日 7:54
> > To: Yang, Wenyou <Wenyou.Yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> > Cc: kbuild-all-JC7UmRfGjtg@public.gmane.org; Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>; Rob Herring
> > <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>; Mark Rutland
> > <mark.rutland-5wv7dgnIgG8@public.gmane.org>; Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>; Kumar
> > Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>; Ferre, Nicolas <Nicolas.FERRE-AIFe0yeh4nA@public.gmane.orgm>;
> > linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Yang, Wenyou
> > <Wenyou.Yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> > Subject: [PATCH] mfd: act8945a: fix platform_no_drv_owner.cocci warnings
> > 
> > drivers/mfd/act8945a.c:100:6-11: No need to set .owner here. The core will do it.
> > 
> >  Remove .owner field if calls are used which set it automatically
> > 
> > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> > 
> > CC: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Reviewed-by: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

Please fix this code up into the original patch and resubmit the set.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[Wenyou Yang]

The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
two subdevices:
 - Regulator
 - Charger

This patch adds documentation for ACT8945A DT bindings.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

 Documentation/devicetree/bindings/mfd/act8945a.txt |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt

diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
new file mode 100644
index 0000000..406db16
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
@@ -0,0 +1,16 @@
+Device-Tree bindings for Active-semi ACT8945A MFD driver
+
+Required properties:
+ - compatible: "active-semi,act8945a".
+ - reg: the I2C slave address for the ACT8945A chip
+
+The chip exposes two subdevices:
+ - a regulators: see ../regulator/act8945a-regulator.txt
+ - a charger: see ../power/act8945a-charger.txt
+
+Example:
+	mfd: act8945a@5b {
+		compatible = "active-semi,act8945a";
+		reg = <0x5b>;
+		status = "okay";
+	};
-- 
1.7.9.5

Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[Rob Herring]

On Fri, Jan 08, 2016 at 10:05:28AM +0800, Wenyou Yang wrote:
> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
>  - Regulator
>  - Charger
> 
> This patch adds documentation for ACT8945A DT bindings.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>

One nit, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> ---
> 
>  Documentation/devicetree/bindings/mfd/act8945a.txt |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..406db16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,16 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> +	mfd: act8945a@5b {

s/act8945a/pmic/

> +		compatible = "active-semi,act8945a";
> +		reg = <0x5b>;
> +		status = "okay";
> +	};
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[Yang, Wenyou]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2498 bytes --]

Hi Rob,

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 2016Äê1ÔÂ9ÈÕ 23:38
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: Lee Jones <lee.jones@linaro.org>; Pawel Moll <pawel.moll@arm.com>; Mark
> Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>;
> Kumar Gala <galak@codeaurora.org>; Ferre, Nicolas
> <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> 
> On Fri, Jan 08, 2016 at 10:05:28AM +0800, Wenyou Yang wrote:
> > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
> > subdevices:
> >  - Regulator
> >  - Charger
> >
> > This patch adds documentation for ACT8945A DT bindings.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> 
> One nit, otherwise:
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 
> > ---
> >
> >  Documentation/devicetree/bindings/mfd/act8945a.txt |   16
> ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt
> > b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > new file mode 100644
> > index 0000000..406db16
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > @@ -0,0 +1,16 @@
> > +Device-Tree bindings for Active-semi ACT8945A MFD driver
> > +
> > +Required properties:
> > + - compatible: "active-semi,act8945a".
> > + - reg: the I2C slave address for the ACT8945A chip
> > +
> > +The chip exposes two subdevices:
> > + - a regulators: see ../regulator/act8945a-regulator.txt
> > + - a charger: see ../power/act8945a-charger.txt
> > +
> > +Example:
> > +	mfd: act8945a@5b {
> 
> s/act8945a/pmic/

The patch is changed in the next verion, add the pmic and charger nodes.

So, I am not add your Acked-by.

> 
> > +		compatible = "active-semi,act8945a";
> > +		reg = <0x5b>;
> > +		status = "okay";
> > +	};
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree"
> > in the body of a message to majordomo@vger.kernel.org More majordomo
> > info at  http://vger.kernel.org/majordomo-info.html


Best Regards,
Wenyou Yang
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·zøœzÚÞz)í…æèw*\x1fjg¬±¨\x1e¶‰šŽŠÝ¢j.ïÛ°\½½MŽúgjÌæa×\x02››–' ™©Þ¢¸\f¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾\a«‘êçzZ+ƒùšŽŠÝ¢j"ú!¶i

Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[Lee Jones]

On Fri, 08 Jan 2016, Wenyou Yang wrote:

> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
>  - Regulator
>  - Charger

Is this really an MFD?  What special handling does it require?

> This patch adds documentation for ACT8945A DT bindings.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> ---
> 
>  Documentation/devicetree/bindings/mfd/act8945a.txt |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..406db16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,16 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> +	mfd: act8945a@5b {

"mfd" is too generic to be a label.

Why do you need a label in any case?

> +		compatible = "active-semi,act8945a";
> +		reg = <0x5b>;
> +		status = "okay";
> +	};

This doesn't look much like an MFD to me.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[Yang, Wenyou]

Hi Lee,

> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@linaro.org]
> Sent: 2016年1月11日 13:49
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>;
> Mark Rutland <mark.rutland@arm.com>; Ian Campbell
> <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Ferre,
> Nicolas <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> 
> On Fri, 08 Jan 2016, Wenyou Yang wrote:
> 
> > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
> > subdevices:
> >  - Regulator
> >  - Charger
> 
> Is this really an MFD?  What special handling does it require?

Yes, this is an MFD, two sub devices: regulators and charger.

> 
> > This patch adds documentation for ACT8945A DT bindings.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> >  Documentation/devicetree/bindings/mfd/act8945a.txt |   16
> ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt
> > b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > new file mode 100644
> > index 0000000..406db16
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > @@ -0,0 +1,16 @@
> > +Device-Tree bindings for Active-semi ACT8945A MFD driver
> > +
> > +Required properties:
> > + - compatible: "active-semi,act8945a".
> > + - reg: the I2C slave address for the ACT8945A chip
> > +
> > +The chip exposes two subdevices:
> > + - a regulators: see ../regulator/act8945a-regulator.txt
> > + - a charger: see ../power/act8945a-charger.txt
> > +
> > +Example:
> > +	mfd: act8945a@5b {
> 
> "mfd" is too generic to be a label.
> 
> Why do you need a label in any case?

Remove the mfd, use act8945a@5b.

> 
> > +		compatible = "active-semi,act8945a";
> > +		reg = <0x5b>;
> > +		status = "okay";
> > +	};
> 
> This doesn't look much like an MFD to me.

I will add the child nodes for its sub devices, inclusive pmic and charger nodes.

> 
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source
> software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog


Best Regards,
Wenyou Yang

Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[Lee Jones]

On Tue, 12 Jan 2016, Yang, Wenyou wrote:

> Hi Lee,
> 
> > -----Original Message-----
> > From: Lee Jones [mailto:lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org]
> > Sent: 2016年1月11日 13:49
> > To: Yang, Wenyou <Wenyou.Yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; Pawel Moll <pawel.moll-AbSShOkvfpQ@public.gmane.orgm>;
> > Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>; Ian Campbell
> > <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>; Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>; Ferre,
> > Nicolas <Nicolas.FERRE-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org;
> > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> > 
> > On Fri, 08 Jan 2016, Wenyou Yang wrote:
> > 
> > > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
> > > subdevices:
> > >  - Regulator
> > >  - Charger
> > 
> > Is this really an MFD?  What special handling does it require?
> 
> Yes, this is an MFD, two sub devices: regulators and charger.
> 
> > 
> > > This patch adds documentation for ACT8945A DT bindings.
> > >
> > > Signed-off-by: Wenyou Yang <wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> > > ---
> > >
> > >  Documentation/devicetree/bindings/mfd/act8945a.txt |   16
> > ++++++++++++++++
> > >  1 file changed, 16 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > new file mode 100644
> > > index 0000000..406db16
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > @@ -0,0 +1,16 @@
> > > +Device-Tree bindings for Active-semi ACT8945A MFD driver
> > > +
> > > +Required properties:
> > > + - compatible: "active-semi,act8945a".
> > > + - reg: the I2C slave address for the ACT8945A chip
> > > +
> > > +The chip exposes two subdevices:
> > > + - a regulators: see ../regulator/act8945a-regulator.txt
> > > + - a charger: see ../power/act8945a-charger.txt
> > > +
> > > +Example:
> > > +	mfd: act8945a@5b {
> > 
> > "mfd" is too generic to be a label.
> > 
> > Why do you need a label in any case?
> 
> Remove the mfd, use act8945a@5b.

Use pmic@5b

> > > +		compatible = "active-semi,act8945a";
> > > +		reg = <0x5b>;
> > > +		status = "okay";
> > > +	};
> > 
> > This doesn't look much like an MFD to me.
> 
> I will add the child nodes for its sub devices, inclusive pmic and charger nodes.

Very well.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

Hi Wenyou,

[auto build test ERROR on v4.4-rc8]
[cannot apply to next-20160307]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Wenyou-Yang/mfd-act8945a-add-Active-semi-ACT8945A-PMIC-MFD-driver/20160108-100943
config: x86_64-allmodconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/built-in.o: In function `act8945a_i2c_probe':
>> act8945a.c:(.text+0x22bb26): undefined reference to `__devm_regmap_init_i2c'
   drivers/built-in.o: In function `act8945a_i2c_init':
>> act8945a.c:(.init.text+0x1a57a): undefined reference to `i2c_register_driver'
   drivers/built-in.o: In function `act8945a_i2c_exit':
>> act8945a.c:(.exit.text+0x68f): undefined reference to `i2c_del_driver'

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 51058 bytes --]

RE: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

[Yang, Wenyou]

Hi,

> -----Original Message-----
> From: kbuild test robot [mailto:lkp@intel.com]
> Sent: 2016年3月8日 11:04
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: kbuild-all@01.org; Lee Jones <lee.jones@linaro.org>; Rob Herring
> <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Rutland
> <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar
> Gala <galak@codeaurora.org>; Ferre, Nicolas <Nicolas.FERRE@atmel.com>;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Yang, Wenyou
> <Wenyou.Yang@atmel.com>
> Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> 
> Hi Wenyou,
> 
> [auto build test ERROR on v4.4-rc8]
> [cannot apply to next-20160307]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improving the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Wenyou-Yang/mfd-act8945a-add-
> Active-semi-ACT8945A-PMIC-MFD-driver/20160108-100943

This is not the latest version, please use http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/405258.html

> config: x86_64-allmodconfig (attached as .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
> 

It works using the commands as below.

$ make mrproper
$ export ARCH=x86_64
$ export CROSS_COMPILE=
$ make allmodconfig
$ make


> All errors (new ones prefixed by >>):
> 
>    drivers/built-in.o: In function `act8945a_i2c_probe':
> >> act8945a.c:(.text+0x22bb26): undefined reference to `__devm_regmap_init_i2c'
>    drivers/built-in.o: In function `act8945a_i2c_init':
> >> act8945a.c:(.init.text+0x1a57a): undefined reference to `i2c_register_driver'
>    drivers/built-in.o: In function `act8945a_i2c_exit':
> >> act8945a.c:(.exit.text+0x68f): undefined reference to `i2c_del_driver'
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


Best Regards,
Wenyou Yang