From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v2 6/9] mfd: add TI LMU hardware fault monitoring driver
Date: Mon, 11 Jan 2016 10:21:17 +0000
Message-ID: <20160111102117.GU14104@x1>
References: <1448521025-2796-1-git-send-email-milo.kim@ti.com>
 <1448521025-2796-7-git-send-email-milo.kim@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-leds-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1448521025-2796-7-git-send-email-milo.kim@ti.com>
Sender: linux-leds-owner@vger.kernel.org
To: Milo Kim <milo.kim@ti.com>
Cc: robh+dt@kernel.org, j.anaszewski@samsung.com, broonie@kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
List-Id: devicetree@vger.kernel.org

On Thu, 26 Nov 2015, Milo Kim wrote:

> LM3633 and LM3697 are TI LMU MFD device.
> Those devices have hardware monitoring feature which detects open or
> short circuit case.
>=20
> Debugfs
> -------
>   Two files are created.
>     open_fault:  check light output channel is open or not.
>     short_fault: check light output channel is shorted or not.
>=20
>   The driver checks the status of backlight output channels.
>   LM3633 and LM3697 have same sequence to check channels, so common
>   functions are used.
>   ABI/testing document is also included.
>=20
> Operations
> ----------
>   Two devices have common control flow but register addresses are dif=
ferent.
>   The structure, 'ti_lmu_reg' is used for register configuration.
>=20
> Event notifier
> --------------
>   After fault monitoring is done, LMU device is reset. So backlight a=
nd
>   LED device should be reinitialized. It notifies an event as soon as
>   the monitoring is done. Then, LM3633 and LM3697 backlight and LED d=
rivers
>   handle this event.
>=20
> Cc: Lee Jones <lee.jones@linaro.org>=20
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-leds@vger.kernel.org=20
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Milo Kim <milo.kim@ti.com>
> ---
>  .../ABI/testing/debugfs-ti-lmu-fault-monitor       |  32 ++
>  drivers/mfd/Kconfig                                |  10 +
>  drivers/mfd/Makefile                               |   1 +
>  drivers/mfd/ti-lmu-fault-monitor.c                 | 405 +++++++++++=
++++++++++

I think this device is part of the MFD, rather than an MFD itself.
Please relocate it to somewhere more appropriate.

>  4 files changed, 448 insertions(+)
>  create mode 100644 Documentation/ABI/testing/debugfs-ti-lmu-fault-mo=
nitor
>  create mode 100644 drivers/mfd/ti-lmu-fault-monitor.c

[...]

--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
=46ollow Linaro: Facebook | Twitter | Blog