From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v6 4/9] mfd: axp20x: Split the driver into core and i2c bits Date: Tue, 12 Jan 2016 07:39:34 +0000 Message-ID: <20160112073934.GJ19803@x1> References: <1450283538-25067-1-git-send-email-wens@csie.org> <1450283538-25067-5-git-send-email-wens@csie.org> <20160111092530.GL14104@x1> Reply-To: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Maxime Ripard , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi , Hans de Goede , Mark Brown , Andy Shevchenko , Rob Herring List-Id: devicetree@vger.kernel.org On Tue, 12 Jan 2016, Chen-Yu Tsai wrote: > Hi, >=20 > On Mon, Jan 11, 2016 at 5:25 PM, Lee Jones wrote: > > On Thu, 17 Dec 2015, Chen-Yu Tsai wrote: > > > >> The axp20x driver assumes the device is i2c based. This is not the > >> case with later chips, which use a proprietary 2 wire serial bus > >> by Allwinner called "Reduced Serial Bus". > >> > >> This patch follows the example of mfd/wm831x and splits it into > >> an interface independent core, and an i2c specific glue layer. > >> MFD_AXP20X and the new MFD_AXP20X_I2C are changed to tristate > >> symbols, allowing the driver to be built as modules. > >> > >> Whitespace and other style errors in the moved i2c specific code > >> have been fixed. Included but unused header files are removed as > >> well. > >> > >> Signed-off-by: Chen-Yu Tsai > >> --- > >> drivers/mfd/Kconfig | 14 ++++--- > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/axp20x-i2c.c | 102 ++++++++++++++++++++++++++++++++++++= +++++++++ > >> drivers/mfd/axp20x.c | 88 +++++++-----------------------------= -- > >> include/linux/mfd/axp20x.h | 33 ++++++++++++++- > >> 5 files changed, 158 insertions(+), 80 deletions(-) > >> create mode 100644 drivers/mfd/axp20x-i2c.c > > > > Acked-by: Lee Jones > > >=20 > [..] >=20 > >> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c > >> new file mode 100644 > >> index 000000000000..b54205677bb2 > >> --- /dev/null > >> +++ b/drivers/mfd/axp20x-i2c.c > >> @@ -0,0 +1,102 @@ > >> +/* > >> + * axp20x-i2c.c - I2C driver for the X-Powers' Power Management ICs >=20 > Do you want me to remove the filenames from these 2 files (axp20x.c and > axp20x-i2c.c) as well? Yes, that would be good. > >> + * AXP20x typically comprises an adaptive USB-Compatible PWM charger,= BUCK DC-DC > >> + * converters, LDOs, multiple 12-bit ADCs of voltage, current and tem= perature > >> + * as well as configurable GPIOs. > >> + * > >> + * This driver supports the I2C variants. > >> + * > >> + * Author: Carlo Caione >=20 > Not sure about the copyright, since it's not mine. Perhaps shoot Carlo an email to see what he thinks. > >> + * This program is free software; you can redistribute it and/or modi= fy > >> + * it under the terms of the GNU General Public License version 2 as > >> + * published by the Free Software Foundation. > >> + */ > >> + >=20 > [..] >=20 > Regards > ChenYu --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.