From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Date: Tue, 12 Jan 2016 08:53:55 +0000 Message-ID: <20160112085355.GR19803@x1> References: <1452218729-11357-1-git-send-email-wenyou.yang@atmel.com> <1452218729-11357-3-git-send-email-wenyou.yang@atmel.com> <20160111054908.GE3331@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Yang, Wenyou" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Ferre, Nicolas" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, 12 Jan 2016, Yang, Wenyou wrote: > Hi Lee, >=20 > > -----Original Message----- > > From: Lee Jones [mailto:lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org] > > Sent: 2016=E5=B9=B41=E6=9C=8811=E6=97=A5 13:49 > > To: Yang, Wenyou > > Cc: Rob Herring ; Pawel Moll ; > > Mark Rutland ; Ian Campbell > > ; Kumar Gala ;= Ferre, > > Nicolas ; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bin= dings > >=20 > > On Fri, 08 Jan 2016, Wenyou Yang wrote: > >=20 > > > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has = two > > > subdevices: > > > - Regulator > > > - Charger > >=20 > > Is this really an MFD? What special handling does it require? >=20 > Yes, this is an MFD, two sub devices: regulators and charger. >=20 > >=20 > > > This patch adds documentation for ACT8945A DT bindings. > > > > > > Signed-off-by: Wenyou Yang > > > --- > > > > > > Documentation/devicetree/bindings/mfd/act8945a.txt | 16 > > ++++++++++++++++ > > > 1 file changed, 16 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mfd/act8945= a.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt > > > b/Documentation/devicetree/bindings/mfd/act8945a.txt > > > new file mode 100644 > > > index 0000000..406db16 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt > > > @@ -0,0 +1,16 @@ > > > +Device-Tree bindings for Active-semi ACT8945A MFD driver > > > + > > > +Required properties: > > > + - compatible: "active-semi,act8945a". > > > + - reg: the I2C slave address for the ACT8945A chip > > > + > > > +The chip exposes two subdevices: > > > + - a regulators: see ../regulator/act8945a-regulator.txt > > > + - a charger: see ../power/act8945a-charger.txt > > > + > > > +Example: > > > + mfd: act8945a@5b { > >=20 > > "mfd" is too generic to be a label. > >=20 > > Why do you need a label in any case? >=20 > Remove the mfd, use act8945a@5b. Use pmic@5b > > > + compatible =3D "active-semi,act8945a"; > > > + reg =3D <0x5b>; > > > + status =3D "okay"; > > > + }; > >=20 > > This doesn't look much like an MFD to me. >=20 > I will add the child nodes for its sub devices, inclusive pmic and ch= arger nodes. Very well. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html