From: Will Deacon <will.deacon@arm.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v3 1/2] PCI: generic: Refactor code to enable reuse by other drivers.
Date: Tue, 12 Jan 2016 17:59:58 +0000 [thread overview]
Message-ID: <20160112175958.GA22186@arm.com> (raw)
In-Reply-To: <1452297553-19911-2-git-send-email-ddaney.cavm@gmail.com>
On Fri, Jan 08, 2016 at 03:59:12PM -0800, David Daney wrote:
> From: David Daney <david.daney@cavium.com>
>
> No change in functionality.
>
> Move structure definitions into a separate header file. Move common
> code to new file with Kconfig machinery to build it. Split probe
> function in to two parts:
>
> - a small driver specific probe function (gen_pci_probe)
>
> - a common probe that can be used by other drivers
> (pci_host_common_probe)
>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> MAINTAINERS | 1 +
> drivers/pci/host/Kconfig | 4 +
> drivers/pci/host/Makefile | 1 +
> drivers/pci/host/pci-host-common.c | 194 ++++++++++++++++++++++++++++++++++++
> drivers/pci/host/pci-host-common.h | 56 +++++++++++
> drivers/pci/host/pci-host-generic.c | 190 +----------------------------------
> 6 files changed, 260 insertions(+), 186 deletions(-)
> create mode 100644 drivers/pci/host/pci-host-common.c
> create mode 100644 drivers/pci/host/pci-host-common.h
Looks fine to me:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2016-01-12 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 23:59 [PATCH v3 0/2] pci: Add host controller driver for Cavium ThunderX PCIe David Daney
2016-01-08 23:59 ` [PATCH v3 1/2] PCI: generic: Refactor code to enable reuse by other drivers David Daney
2016-01-12 17:59 ` Will Deacon [this message]
2016-01-08 23:59 ` [PATCH v3 2/2] pci, pci-thunder-pem: Add PCIe host driver for ThunderX processors David Daney
2016-01-09 22:53 ` Rob Herring
2016-01-12 21:53 ` [PATCH v3 0/2] pci: Add host controller driver for Cavium ThunderX PCIe Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112175958.GA22186@arm.com \
--to=will.deacon@arm.com \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).