From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v1 1/5] mtd: atmel_nand: Do not warn on bitflips Date: Wed, 13 Jan 2016 18:54:21 +0100 Message-ID: <20160113185421.22e1cb9c@bbrezillon> References: <1452702857-2240-1-git-send-email-romain.izard.pro@gmail.com> <1452702857-2240-2-git-send-email-romain.izard.pro@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1452702857-2240-2-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Romain Izard Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Josh Wu , Nicolas Ferre , Yang Wenyou List-Id: devicetree@vger.kernel.org On Wed, 13 Jan 2016 17:34:13 +0100 Romain Izard wrote: > When using multi-bit ECC, it is normal for the NAND Flash driver to > correct bit errors during the life of the product. Those errors will > only be cleared once a threshold has been reached, and corrections can > occur regularly before this. > > Use only dev_dbg and not dev_info to report the bitflips, to keep the > system log clean when everything works correctly. > > Signed-off-by: Romain Izard > Acked-by: Wenyou Yang Reviewed-by: Boris Brezillon > --- > drivers/mtd/nand/atmel_nand.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > index 46010bd895b1..9d71f9e6a8de 100644 > --- a/drivers/mtd/nand/atmel_nand.c > +++ b/drivers/mtd/nand/atmel_nand.c > @@ -824,7 +824,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc, > *(buf + byte_pos) ^= (1 << bit_pos); > > pos = sector_num * host->pmecc_sector_size + byte_pos; > - dev_info(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", > + dev_dbg(host->dev, "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", > pos, bit_pos, err_byte, *(buf + byte_pos)); > } else { > /* Bit flip in OOB area */ > @@ -834,7 +834,7 @@ static void pmecc_correct_data(struct mtd_info *mtd, uint8_t *buf, uint8_t *ecc, > ecc[tmp] ^= (1 << bit_pos); > > pos = tmp + nand_chip->ecc.layout->eccpos[0]; > - dev_info(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", > + dev_dbg(host->dev, "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n", > pos, bit_pos, err_byte, ecc[tmp]); > } > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html