From: Lee Jones <lee.jones@linaro.org>
To: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
Cc: Peter Korsgaard <peter@korsgaard.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A
Date: Thu, 14 Jan 2016 06:19:36 +0000 [thread overview]
Message-ID: <20160114061936.GM27358@x1> (raw)
In-Reply-To: <B256D81BAE5131468A838E5D7A243641D63EBC6E@penmbx01>
On Thu, 14 Jan 2016, Yang, Wenyou wrote:
> > -----Original Message-----
> > From: Peter Korsgaard [mailto:jacmet@gmail.com] On Behalf Of Peter Korsgaard
> > Sent: 2016年1月13日 22:22
> > To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> > Cc: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
> > Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark
> > Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>;
> > Kumar Gala <galak@codeaurora.org>; Krzysztof Kozlowski
> > <k.kozlowski@samsung.com>; devicetree@vger.kernel.org; Ferre, Nicolas
> > <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org; Javier Martinez
> > Canillas <javier@dowhile0.org>; Lee Jones <lee.jones@linaro.org>; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for
> > ACT8945A
> >
> > >>>>> "Wenyou" == Wenyou Yang <wenyou.yang@atmel.com> writes:
> >
> > > This patch adds new regulator driver to support ACT8945A MFD > chip's
> > regulators.
> >
> > > The ACT8945A has three step-down DC/DC converters and four > low-dropout
> > regulators.
> >
> > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> >
> > Isn't the regulator part of the act8945a identical to act8865? Can't we just use the
> > existing act8865-regulator.c driver? (E.G. support 8865 variant in the mfd driver,
> > but only register the regulator sub device?)
>
> Yes, the regulator part of the act8945a is identical to act8865.
>
> But the act8865-regulator driver is a struct i2c_driver, and the mfd sub-device driver is a platform_driver driver, it is not easy to use it.
Take a look at some existing files with the pattern
drivers/mfd/*{spi,i2c,core}.c to see how this might be possible.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-01-14 6:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 8:17 [PATCH v2 0/2] regulator: act8945a: add regulator driver for the sub-device of ACT8945A MFD Wenyou Yang
[not found] ` <1452586629-1117-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2016-01-12 8:17 ` [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Wenyou Yang
2016-01-13 14:22 ` Peter Korsgaard
[not found] ` <87oacp5zl7.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
2016-01-14 1:23 ` Yang, Wenyou
2016-01-14 6:19 ` Lee Jones [this message]
2016-01-14 7:27 ` Peter Korsgaard
[not found] ` <87egdk39ji.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
2016-01-14 8:07 ` Yang, Wenyou
2016-01-14 11:43 ` Peter Korsgaard
2016-01-14 12:46 ` Yang, Wenyou
[not found] ` <87a8o82xq3.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
2016-01-20 7:37 ` Yang, Wenyou
2016-01-20 7:41 ` Peter Korsgaard
2016-01-12 8:17 ` [PATCH v2 2/2] regulator: add documentation for ACT8945A's regulator DT bindings Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114061936.GM27358@x1 \
--to=lee.jones@linaro.org \
--cc=Nicolas.FERRE@atmel.com \
--cc=Wenyou.Yang@atmel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@dowhile0.org \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peter@korsgaard.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).