From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Caleb Crome <caleb@crome.org>
Cc: Timur Tabi <timur@tabi.org>, Mark Brown <broonie@kernel.org>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options
Date: Fri, 15 Jan 2016 10:38:24 -0800 [thread overview]
Message-ID: <20160115183824.GB31703@Asurada-Nvidia> (raw)
In-Reply-To: <CAG5mAdy553q4Te5755575WaiLxGRp43h=WVH6QzF7idsaCnhbg@mail.gmail.com>
On Fri, Jan 15, 2016 at 09:03:28AM -0800, Caleb Crome wrote:
> If nobody objects, we can just set the value to 4 and be done with it.
I agree. And we may apply it only to i.MX platforms with DMA if
other platform owners feel comfortable with the previous settings.
> Another question: is the watermark ever going to be different than
> maxburst? Is there any reason to have them different?
The watermark is merely a threshold to trigger a DMA request. The
only relationship with the burst size is that each burst transfer
should not carry more data than the number of empty slots; FIFO
under/overflow occurs otherwise. So it's just more efficient and
safer to set an identical value to both of them. I don't think
it will cause functional problems to set TFWM to 4 and burst size
to 1 -- It just lets DMA operate in a single data transfer mode.
next prev parent reply other threads:[~2016-01-15 18:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 16:29 [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options Caleb Crome
[not found] ` <1452788982-11583-1-git-send-email-caleb-EebDDntmC0DYtjvyW6yDsg@public.gmane.org>
2016-01-14 20:18 ` Nicolin Chen
2016-01-14 21:26 ` Caleb Crome
2016-01-15 2:45 ` Nicolin Chen
2016-01-15 4:56 ` Caleb Crome
2016-01-15 18:12 ` Nicolin Chen
2016-01-15 1:31 ` Timur Tabi
2016-01-15 2:33 ` Nicolin Chen
2016-01-15 3:25 ` Rob Herring
[not found] ` <56984BE7.2050303-N01EOCouUvQ@public.gmane.org>
2016-01-15 13:13 ` Mark Brown
[not found] ` <20160115131325.GW6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-15 13:46 ` Timur Tabi
2016-01-15 17:03 ` Caleb Crome
2016-01-15 18:38 ` Nicolin Chen [this message]
2016-01-15 18:49 ` Caleb Crome
2016-01-15 18:57 ` Nicolin Chen
2016-01-15 19:10 ` Caleb Crome
2016-01-15 19:23 ` Nicolin Chen
2016-01-15 19:49 ` Timur Tabi
[not found] ` <CAG5mAdyUfSuCqA4_342MS2AyshvuyeiYsjQyRqifmqVhn4T2xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-16 14:15 ` Timur Tabi
2016-01-17 23:34 ` Caleb Crome
2016-01-15 19:51 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115183824.GB31703@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox