From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options Date: Fri, 15 Jan 2016 11:23:21 -0800 Message-ID: <20160115192320.GA12418@Asurada-Nvidia> References: <1452788982-11583-1-git-send-email-caleb@crome.org> <20160114201858.GA17567@Asurada-Nvidia> <56984BE7.2050303@tabi.org> <20160115131325.GW6588@sirena.org.uk> <5698F846.5080604@tabi.org> <20160115183824.GB31703@Asurada-Nvidia> <20160115185736.GC31703@Asurada-Nvidia> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Caleb Crome Cc: devicetree@vger.kernel.org, "alsa-devel@alsa-project.org" , Timur Tabi , Xiubo Li , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown List-Id: devicetree@vger.kernel.org On Fri, Jan 15, 2016 at 11:10:29AM -0800, Caleb Crome wrote: > Shall I submit a patch that sets the value to 4 for for any/all of the > above? Should it be different based on whether fiq is enabled. Maybe > set it to 4 for whenever DMA is used, and to 13 whenever FIQ is used? A possible solution: Use the original settings (depth - 2) as a common configuration in the main probe() and overwrite it in the fsl_ssi_imx_probe() if detecting a use_dma flag.