From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antony Pavlov Subject: Re: [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name Date: Sat, 16 Jan 2016 08:02:05 +0300 Message-ID: <20160116080205.0b6e84c9e531b0cfd845b67b@gmail.com> References: <1452759657-7114-1-git-send-email-antonynpavlov@gmail.com> <56993EF5.9040008@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <56993EF5.9040008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Daney Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Alban Bedel , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 15 Jan 2016 10:48:21 -0800 David Daney wrote: > On 01/14/2016 12:20 AM, Antony Pavlov wrote: > > The correct name for aliases node is "aliases" not "alias". > > > > An overview of the "aliases" node usage can be found > > on the device tree usage page at devicetree.org [1]. > > > > Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2]. > > > > [1] http://devicetree.org/Device_Tree_Usage#aliases_Node > > [2] https://www.power.org/documentation/epapr-version-1-1/ > > > > Signed-off-by: Antony Pavlov > > Cc: Alban Bedel > > Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > --- > > arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arc= h/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts > > index 003015a..4b6d38c 100644 > > --- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts > > +++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts > > @@ -9,7 +9,7 @@ > > compatible =3D "tplink,tl-wr1043nd-v1", "qca,ar9132"; > > model =3D "TP-Link TL-WR1043ND Version 1"; > > > > - alias { > > + aliases { > > serial0 =3D "/ahb/apb/uart@18020000"; > > }; >=20 > What uses this alias? If the answer is nothing (likely, as it was=20 > broken and nobody seems to have noticed), just remove the whole thing= =2E I have used ar9132_tl_wr1043nd_v1.dts as a template for AR9331-based bo= ard dts-file. AR9331 uses it's own very special UART implementation (the ar933x_uart.= c driver is used). ar933x_uart.c relies on alias and does not work if alias is not set. I have not yet runned linux on TL-WR1034ND, but I suppose that uart ali= as is not=20 actually used for TL-WR1034ND and this aliases node can be safely remov= ed. Alban, have you any comments? --=A0 Best regards, =A0 Antony Pavlov -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html