From: Alban <albeu@free.fr>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Aban Bedel <albeu@free.fr>, David Daney <ddaney.cavm@gmail.com>,
linux-mips@linux-mips.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name
Date: Wed, 20 Jan 2016 00:43:36 +0100 [thread overview]
Message-ID: <20160120004336.2b89a5f6@tock> (raw)
In-Reply-To: <20160116080205.0b6e84c9e531b0cfd845b67b@gmail.com>
On Sat, 16 Jan 2016 08:02:05 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:
> On Fri, 15 Jan 2016 10:48:21 -0800
> David Daney <ddaney.cavm@gmail.com> wrote:
>
> > On 01/14/2016 12:20 AM, Antony Pavlov wrote:
> > > The correct name for aliases node is "aliases" not "alias".
> > >
> > > An overview of the "aliases" node usage can be found
> > > on the device tree usage page at devicetree.org [1].
> > >
> > > Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2].
> > >
> > > [1] http://devicetree.org/Device_Tree_Usage#aliases_Node
> > > [2] https://www.power.org/documentation/epapr-version-1-1/
> > >
> > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > > Cc: Alban Bedel <albeu@free.fr>
> > > Cc: linux-mips@linux-mips.org
> > > Cc: devicetree@vger.kernel.org
> > > ---
> > > arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > > b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts index
> > > 003015a..4b6d38c 100644 ---
> > > a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts +++
> > > b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts @@ -9,7 +9,7 @@
> > > compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
> > > model = "TP-Link TL-WR1043ND Version 1";
> > >
> > > - alias {
> > > + aliases {
> > > serial0 = "/ahb/apb/uart@18020000";
> > > };
> >
> > What uses this alias? If the answer is nothing (likely, as it was
> > broken and nobody seems to have noticed), just remove the whole
> > thing.
>
> I have used ar9132_tl_wr1043nd_v1.dts as a template for AR9331-based
> board dts-file. AR9331 uses it's own very special UART implementation
> (the ar933x_uart.c driver is used). ar933x_uart.c relies on alias and
> does not work if alias is not set. I have not yet runned linux on
> TL-WR1034ND, but I suppose that uart alias is not actually used for
> TL-WR1034ND and this aliases node can be safely removed.
>
> Alban, have you any comments?
David is right, we should just remove it.
Alban
next prev parent reply other threads:[~2016-01-19 23:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 8:20 [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name Antony Pavlov
[not found] ` <1452759657-7114-1-git-send-email-antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-14 14:45 ` Alban
2016-01-15 18:48 ` David Daney
[not found] ` <56993EF5.9040008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-16 5:02 ` Antony Pavlov
2016-01-19 23:43 ` Alban [this message]
2016-01-20 15:22 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120004336.2b89a5f6@tock \
--to=albeu@free.fr \
--cc=antonynpavlov@gmail.com \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).