Re: [PATCH v4 2/2] gpio: sn65hvs885: Add DT binding documentation

[Rob Herring <robh@kernel.org>]

On Thu, Jan 21, 2016 at 07:41:36AM +0100, Sean Nyekjaer wrote:
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
> ---
> Changes since v3:
> - Added gpio-controller and gpio cells flags
> 
>  Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
> new file mode 100644
> index 0000000..6d99c9e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
> @@ -0,0 +1,11 @@
> +* TI SN65HVS885 digital-input serializer
> +
> +Example:

The example does not serve as documentation. You need to list the 
properties and allowed values, required vs. optional, and point to 
common bindings you are using as appropriate (i.e. gpio).

> +	sn65hvs885@3 {
> +		compatible = "sn65hvs885";

Also, this needs a vendor prefix, so "ti,sn65hvs885".

> +		spi-max-frequency = <10000000>;
> +		reg = <0>;
> +		gpio-controller;
> +		#gpio-cells = <1>;
> +	};
> +
> -- 
> 2.7.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html